From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 502041FF13B for ; Wed, 11 Mar 2026 10:46:00 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BC41512A70; Wed, 11 Mar 2026 10:45:44 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH storage v2 07/11] partially fix #7094: lvm: snapshot delete: ensure commit target is large enough Date: Wed, 11 Mar 2026 10:44:46 +0100 Message-ID: <20260311094506.22359-8-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260311094506.22359-1-f.ebner@proxmox.com> References: <20260311094506.22359-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773222275360 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.001 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: AXA23IMGAACKDR6QJFZ2PLHZZZ7FHXST X-Message-ID-Hash: AXA23IMGAACKDR6QJFZ2PLHZZZ7FHXST X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: For LVM storages using 'snapshot-as-volume-chain', it's necessary to ensure that the size for the LV of the target snapshot volume is large enough before doing a commit operation. This fixes the offline case. Signed-off-by: Fiona Ebner --- src/PVE/Storage/LVMPlugin.pm | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm index d34dfef..512c217 100644 --- a/src/PVE/Storage/LVMPlugin.pm +++ b/src/PVE/Storage/LVMPlugin.pm @@ -1205,6 +1205,14 @@ sub volume_snapshot_delete { # the snapshot to child if (!$parentsnap) { print "$volname: deleting snapshot '$snap' by commiting snapshot '$childsnap'\n"; + + my $snap_size = $snapshots->{$snap}->{'virtual-size'}; + my $child_size = $snapshots->{$childsnap}->{'virtual-size'}; + if (defined($child_size) && defined($snap_size) && $child_size > $snap_size) { + print "resize '$snap' ($snap_size bytes) to match '$childsnap' ($child_size bytes)\n"; + $class->volume_resize($scfg, $storeid, $volname, $child_size, $running, $snap); + } + print "running 'qemu-img commit $childpath'\n"; #can't use -d here, as it's an lvm volume $cmd = ['/usr/bin/qemu-img', 'commit', $childpath]; -- 2.47.3