From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 411441FF13B for ; Wed, 11 Mar 2026 10:45:21 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 472E81242A; Wed, 11 Mar 2026 10:45:16 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH storage v2 03/11] plugin: document volume_resize() method Date: Wed, 11 Mar 2026 10:44:42 +0100 Message-ID: <20260311094506.22359-4-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260311094506.22359-1-f.ebner@proxmox.com> References: <20260311094506.22359-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773222275117 X-SPAM-LEVEL: Spam detection results: 1 AWL -0.002 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLACK 3 Contains an URL listed in the URIBL blacklist [plugin.pm] Message-ID-Hash: DMXIS6CZHDV53N4T4YGXSVQXJBP246HF X-Message-ID-Hash: DMXIS6CZHDV53N4T4YGXSVQXJBP246HF X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Based on Max's submission [0] and Fabian's reply there. Also document that the size is a multiple of 1024 and that padding to a larger size is allowed. [0]: https://lore.proxmox.com/pve-devel/20250326142059.261938-8-m.carrara@proxmox.com/ Signed-off-by: Fiona Ebner --- src/PVE/Storage/Plugin.pm | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm index ffe9464..9e93bab 100644 --- a/src/PVE/Storage/Plugin.pm +++ b/src/PVE/Storage/Plugin.pm @@ -1340,6 +1340,24 @@ sub volume_size_info { } +=head3 volume_resize + + $plugin->volume_resize(\%scfg, $storeid, $volname, $size, $running); + +Resize a volume to the new C<$size> in bytes. The size is guaranteed to be a multiple of C<1024>. +The implementation may pad to a larger size if required. In case of virtual machines, C<$running> +indicates that the VM is currently running and the call will be followed by a C QMP +command in QEMU. If resizing is supported natively via QEMU (for example, when using librbd), then +the plugin should simply return if the VM is running. For containers, C<$running> will always be +C<0>. + +Cs in case of errors, or if the underlying storage implementation or the volume's format +doesn't support resizing. + +This function should not return any value. + +=cut + sub volume_resize { my ($class, $scfg, $storeid, $volname, $size, $running) = @_; -- 2.47.3