From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 32D841FF13B for ; Wed, 11 Mar 2026 10:46:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1E85012DC1; Wed, 11 Mar 2026 10:45:46 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH storage v2 02/11] plugin: volume snapshot info: also return virtual size Date: Wed, 11 Mar 2026 10:44:41 +0100 Message-ID: <20260311094506.22359-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260311094506.22359-1-f.ebner@proxmox.com> References: <20260311094506.22359-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773222275056 X-SPAM-LEVEL: Spam detection results: 1 AWL -0.002 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLACK 3 Contains an URL listed in the URIBL blacklist [plugin.pm] Message-ID-Hash: YEI6TMT4VX72IEW4DSYT7VSBNVJ62T6G X-Message-ID-Hash: YEI6TMT4VX72IEW4DSYT7VSBNVJ62T6G X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: For LVM storages using 'snapshot-as-volume-chain', it's necessary to check that the size for the LV of the target snapshot volume is large enough before doing a commit operation. Returning the virtual size of the volume at the time the snapshot was taken in the result of volume_snapshot_info() makes this easy to check. Signed-off-by: Fiona Ebner --- src/PVE/Storage/LVMPlugin.pm | 1 + src/PVE/Storage/Plugin.pm | 3 +++ 2 files changed, 4 insertions(+) diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm index 32a8339..97c6b0a 100644 --- a/src/PVE/Storage/LVMPlugin.pm +++ b/src/PVE/Storage/LVMPlugin.pm @@ -909,6 +909,7 @@ sub volume_snapshot_info { $info->{$snapname}->{file} = $snapfile; $info->{$snapname}->{volname} = "$snapvolname"; $info->{$snapname}->{volid} = "$storeid:$snapvolname"; + $info->{$snapname}->{'virtual-size'} = $snap->{'virtual-size'}; my $parentfile = $snap->{'backing-filename'}; if ($parentfile) { diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm index d901853..ffe9464 100644 --- a/src/PVE/Storage/Plugin.pm +++ b/src/PVE/Storage/Plugin.pm @@ -1834,6 +1834,8 @@ Required values are: =item C: The volume ID of the external snapshot volume. +=item C: The virtual size of the volume recorded by the snapshot. + =item C: The name of the child snapshot in the volume chain. Not set if there is no child. =item C: The name of the parent snapshot in the volume chain. Not set if there is no parent. @@ -1913,6 +1915,7 @@ sub volume_snapshot_info { $info->{$snapname}->{file} = $snapfile; $info->{$snapname}->{volname} = "$snapvolname"; $info->{$snapname}->{volid} = "$storeid:$snapvolname"; + $info->{$snapname}->{'virtual-size'} = $snap->{'virtual-size'}; $info->{$snapname}->{ext} = 1; my $parentfile = $snap->{'backing-filename'}; -- 2.47.3