From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 6F4B61FF13B for ; Wed, 11 Mar 2026 10:46:28 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1734813157; Wed, 11 Mar 2026 10:45:49 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH storage v2 10/11] plugin: volume snapshot info: do not set 'ext' property Date: Wed, 11 Mar 2026 10:44:49 +0100 Message-ID: <20260311094506.22359-11-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260311094506.22359-1-f.ebner@proxmox.com> References: <20260311094506.22359-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773222275547 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.501 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLACK 3 Contains an URL listed in the URIBL blacklist [plugin.pm] Message-ID-Hash: AN54XS6LJC5XZYCHZJB5QVSJV2WZODPF X-Message-ID-Hash: AN54XS6LJC5XZYCHZJB5QVSJV2WZODPF X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The 'snapshot-as-volume-chain' storage configuration option determines whether handling for external snapshots is done or not. The 'ext' marker returned by volume_snapshot_info() doesn't add any information. Also, the LVM plugin didn't return the 'ext' marker, making it inconsistent. Remove the marker. Signed-off-by: Fiona Ebner --- src/PVE/Storage/Plugin.pm | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm index b2545ce..32ae4c6 100644 --- a/src/PVE/Storage/Plugin.pm +++ b/src/PVE/Storage/Plugin.pm @@ -1154,7 +1154,6 @@ sub free_image { ) { my $snap = $snapshots->{$snapid}; next if $snapid eq 'current'; - next if !$snap->{ext}; eval { free_snap_image($class, $storeid, $scfg, $volname, $snapid); }; warn $@ if $@; } @@ -1865,9 +1864,6 @@ Required values are: =item C: Number that determines the position in the backing chain. C<0> for the current image, one more for each step further back in the volume chain. -=item C: May be set if the snapshot is external when internal snapshots are also supported by -the storage. - =back For replication support, returns an empty hash if the volume does not exist. Required values are: @@ -1930,7 +1926,6 @@ sub volume_snapshot_info { $info->{$snapname}->{volname} = "$snapvolname"; $info->{$snapname}->{volid} = "$storeid:$snapvolname"; $info->{$snapname}->{'virtual-size'} = $snap->{'virtual-size'}; - $info->{$snapname}->{ext} = 1; my $parentfile = $snap->{'backing-filename'}; if ($parentfile) { -- 2.47.3