From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A7E601FF144 for ; Tue, 10 Mar 2026 11:16:49 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5EA7A16FA0; Tue, 10 Mar 2026 11:16:40 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH common v4 1/5] file: set contents: use strict UTF-8 encoding with $force_utf8 Date: Tue, 10 Mar 2026 11:13:30 +0100 Message-ID: <20260310101631.32870-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260310101631.32870-1-f.ebner@proxmox.com> References: <20260310101631.32870-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773137762173 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.068 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 7VXSHFLSNWGQMGYVQYS4E5UIFGBKPAPM X-Message-ID-Hash: 7VXSHFLSNWGQMGYVQYS4E5UIFGBKPAPM X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: 'perldoc Encode' states: > "UTF-8" means UTF-8 in its current sense, which is conservative and > strict and security-conscious, whereas "utf8" means UTF-8 in its > former sense, which was liberal and loose and lax. Currently, the following callers use the $force_utf8 flag: 1. Notification config 2. The SDN fabrics config 3. The PBS password file The first two pass the contents to Rust, and the latter already uses the strict 'UTF-8' encoding when decoding. So in all cases, after this patch, any potential issues are just caught earlier, before writing. Signed-off-by: Fiona Ebner --- src/PVE/File.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/File.pm b/src/PVE/File.pm index 7d0f7ab..89884a8 100644 --- a/src/PVE/File.pm +++ b/src/PVE/File.pm @@ -60,7 +60,7 @@ sub file_set_contents($filename, $data, $perm = 0644, $force_utf8 = 0) { die "unable to open file '$tmpname' - $!\n" if !$fh; if ($force_utf8) { - $data = encode("utf8", $data); + $data = encode("UTF-8", $data); } else { # Encode wide characters with print before passing them to syswrite my $unencoded_data = $data; -- 2.47.3