From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 251531FF144 for ; Tue, 10 Mar 2026 11:17:22 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 828C317419; Tue, 10 Mar 2026 11:17:11 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [RFC common/cluster v4 0/5] cluster files: support registering UTF-8 configuration file Date: Tue, 10 Mar 2026 11:13:29 +0100 Message-ID: <20260310101631.32870-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773137762116 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.068 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 5WZCXHTURPB2K64PODLCKNNWR5AT4O3F X-Message-ID-Hash: 5WZCXHTURPB2K64PODLCKNNWR5AT4O3F X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Changes in v4: * rather than searching for wide characters, tell parse_config() directly whether the file was registered as UTF-8 Changes in v3: * rebase on current master. * add patch to use strict UTF-8 encoding when writing. * use strict UTF-8 for {de,en}coding in the rest of the series. * let cfs_register_file() take an $options parameter rather than an $utf8 parameter, so future call sites are more readable. Changes in v2: * rebase on current master. * use qw(encode) when importing Encode module. A configuration file registered as UTF-8 will be automatically decoded from UTF-8 to Perl's internal string format after reading and encoded in the other direction before writing. Patch 1/5 also makes sense without the rest of the RFC. Note that patch 4/5 (required by 3/5) is a versioned breaks for libpve-access-control which still needs to be bumped! Could be avoided by keeping the implicit return of cfs_register_file(), but that's bad for encapsulation. Versioned dependency bump pve-cluster -> pve-common needed! common: Fiona Ebner (2): file: set contents: use strict UTF-8 encoding with $force_utf8 section config: prepare for supporting UTF-8 encoded configurations src/PVE/File.pm | 2 +- src/PVE/SectionConfig.pm | 29 ++++++++++++++++++++++++----- 2 files changed, 25 insertions(+), 6 deletions(-) cluster: Fiona Ebner (3): cfs register file: avoid implicit return d/control: add versioned breaks for libpve-access-control cluster files: support registering UTF-8 configuration file debian/control | 2 +- src/PVE/Cluster.pm | 20 ++++++++++++++++---- 2 files changed, 17 insertions(+), 5 deletions(-) Summary over all repositories: 4 files changed, 42 insertions(+), 11 deletions(-) -- Generated by git-murpp 0.5.0