From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 80C8D1FF144 for ; Tue, 10 Mar 2026 10:11:50 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7800014E0B; Tue, 10 Mar 2026 10:11:44 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Subject: [PATCH manager] fix #7386: ui: make memory window compatible with older browsers again Date: Tue, 10 Mar 2026 10:10:42 +0100 Message-ID: <20260310091141.814416-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.039 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: I7VKHNI5RCQ6ZO2LEFABY2WYGTWJVKXU X-Message-ID-Hash: I7VKHNI5RCQ6ZO2LEFABY2WYGTWJVKXU X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: while this is supported in most modern browsers, it's not supported in (still updated) older Firefox ESR versions. This was introduced in ECMAscript version 2025, which is against our style guide that suggests we should stick to ES 2024 features for trixie. Signed-off-by: Dominik Csapak --- Usually I'd not go back with such things, but since it's just a one line fix and technically the code was against our style guide, i think it's fine. www/manager6/qemu/MemoryEdit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/qemu/MemoryEdit.js b/www/manager6/qemu/MemoryEdit.js index ff4a7545..0f6bd656 100644 --- a/www/manager6/qemu/MemoryEdit.js +++ b/www/manager6/qemu/MemoryEdit.js @@ -65,7 +65,7 @@ Ext.define('PVE.qemu.MemoryInputPanel', { } if (deleteSet.size > 0) { - res.delete = deleteSet.keys().toArray().join(','); + res.delete = Array.from(deleteSet.keys()).join(','); } return res; -- 2.47.3