From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 1E6791FF136 for ; Mon, 09 Mar 2026 18:00:03 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 85F6B55B4; Mon, 9 Mar 2026 17:59:30 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server v2 14/18] blockdev: switch blockdev_delete() to use QMP peer Date: Mon, 9 Mar 2026 17:58:40 +0100 Message-ID: <20260309165913.219308-15-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260309165913.219308-1-f.ebner@proxmox.com> References: <20260309165913.219308-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773075525285 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.004 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: W2IIPOZOPP2ABWKZNSD6XG7H6E5XEZOD X-Message-ID-Hash: W2IIPOZOPP2ABWKZNSD6XG7H6E5XEZOD X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: In preparation to allow snapshot operations for QSD-FUSE-exported TPM states. Signed-off-by: Fiona Ebner --- src/PVE/QemuServer/VolumeChain.pm | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/src/PVE/QemuServer/VolumeChain.pm b/src/PVE/QemuServer/VolumeChain.pm index 8dd29d61..d2042614 100644 --- a/src/PVE/QemuServer/VolumeChain.pm +++ b/src/PVE/QemuServer/VolumeChain.pm @@ -64,9 +64,9 @@ sub blockdev_external_snapshot { } sub blockdev_delete { - my ($storecfg, $vmid, $drive, $file_blockdev, $fmt_blockdev, $snap) = @_; + my ($storecfg, $qmp_peer, $drive, $file_blockdev, $fmt_blockdev, $snap) = @_; - eval { PVE::QemuServer::Blockdev::detach(vm_qmp_peer($vmid), $fmt_blockdev->{'node-name'}); }; + eval { PVE::QemuServer::Blockdev::detach($qmp_peer, $fmt_blockdev->{'node-name'}); }; warn "detaching block node for $file_blockdev->{filename} failed - $@" if $@; #delete the file (don't use vdisk_free as we don't want to delete all snapshot chain) @@ -260,7 +260,12 @@ sub blockdev_commit { ); blockdev_delete( - $storecfg, $vmid, $drive, $src_file_blockdev, $src_fmt_blockdev, $src_snap, + $storecfg, + vm_qmp_peer($vmid), + $drive, + $src_file_blockdev, + $src_fmt_blockdev, + $src_snap, ); }; my $err = $@; @@ -335,7 +340,14 @@ sub blockdev_stream { vm_qmp_peer($vmid), undef, $jobs, 'auto', 0, 'stream', ); - blockdev_delete($storecfg, $vmid, $drive, $snap_file_blockdev, $snap_fmt_blockdev, $snap); + blockdev_delete( + $storecfg, + vm_qmp_peer($vmid), + $drive, + $snap_file_blockdev, + $snap_fmt_blockdev, + $snap, + ); } 1; -- 2.47.3