From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 327F31FF136 for ; Mon, 09 Mar 2026 16:41:11 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 00555A47; Mon, 9 Mar 2026 16:41:02 +0100 (CET) From: Filip Schauer To: pve-devel@lists.proxmox.com Subject: [PATCH proxmox] oci: ignore tests that require to be run as UID 0 Date: Mon, 9 Mar 2026 16:39:25 +0100 Message-ID: <20260309154055.139983-1-f.schauer@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773070827087 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.308 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: TNAKQGCDTM5TNPBKFRUAA3QW5BVFSDHC X-Message-ID-Hash: TNAKQGCDTM5TNPBKFRUAA3QW5BVFSDHC X-MailFrom: f.schauer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This prevents unprivileged test runs from failing when extracting test artifacts containing files with UID 0. The tests can still run without root privileges using a user namespace: unshare -r cargo test -- --include-ignored Signed-off-by: Filip Schauer --- proxmox-oci/tests/extract_replace.rs | 3 +++ proxmox-oci/tests/extract_whiteouts.rs | 3 +++ 2 files changed, 6 insertions(+) diff --git a/proxmox-oci/tests/extract_replace.rs b/proxmox-oci/tests/extract_replace.rs index eb41f9e3..2c8ea7ed 100644 --- a/proxmox-oci/tests/extract_replace.rs +++ b/proxmox-oci/tests/extract_replace.rs @@ -4,6 +4,7 @@ use proxmox_oci::{parse_and_extract_image, Arch}; use proxmox_sys::fs::make_tmp_dir; #[test] +#[ignore = "Must be run as UID 0 (unshare -r cargo test -- --include-ignored)"] fn test_replace_file() { let extract_dir = make_tmp_dir("/tmp/", None).unwrap(); @@ -23,6 +24,7 @@ fn test_replace_file() { } #[test] +#[ignore = "Must be run as UID 0 (unshare -r cargo test -- --include-ignored)"] fn test_replace_file_with_dir() { let extract_dir = make_tmp_dir("/tmp/", None).unwrap(); @@ -40,6 +42,7 @@ fn test_replace_file_with_dir() { } #[test] +#[ignore = "Must be run as UID 0 (unshare -r cargo test -- --include-ignored)"] fn test_replace_dir_with_file() { let extract_dir = make_tmp_dir("/tmp/", None).unwrap(); diff --git a/proxmox-oci/tests/extract_whiteouts.rs b/proxmox-oci/tests/extract_whiteouts.rs index 71ec4dea..0333dac9 100644 --- a/proxmox-oci/tests/extract_whiteouts.rs +++ b/proxmox-oci/tests/extract_whiteouts.rs @@ -40,6 +40,7 @@ fn test_whiteout_root_parent_breakout() { } #[test] +#[ignore = "Must be run as UID 0 (unshare -r cargo test -- --include-ignored)"] fn test_whiteout_current_directory() { let extract_dir = make_tmp_dir("/tmp/", None).unwrap(); @@ -57,6 +58,7 @@ fn test_whiteout_current_directory() { } #[test] +#[ignore = "Must be run as UID 0 (unshare -r cargo test -- --include-ignored)"] fn test_whiteout_symlink() { let extract_dir = make_tmp_dir("/tmp/", None).unwrap(); @@ -75,6 +77,7 @@ fn test_whiteout_symlink() { } #[test] +#[ignore = "Must be run as UID 0 (unshare -r cargo test -- --include-ignored)"] fn test_whiteout_dead_symlink_parent() { let extract_dir = make_tmp_dir("/tmp/", None).unwrap(); -- 2.47.3