From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 966231FF136 for ; Mon, 09 Mar 2026 14:07:37 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AAC073379D; Mon, 9 Mar 2026 14:07:30 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server v2 2/4] pbs: properly encode PBS password as UTF-8 when setting the environment variable Date: Mon, 9 Mar 2026 14:06:41 +0100 Message-ID: <20260309130653.90674-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260309130653.90674-1-f.ebner@proxmox.com> References: <20260309130653.90674-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773061584143 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.072 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 6M5LOMBFW7VTA4PHX7LMTGETCSZ7UK7Z X-Message-ID-Hash: 6M5LOMBFW7VTA4PHX7LMTGETCSZ7UK7Z X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The PBS password is saved as UTF-8 and decoded to Perl's internal string representation upon reading from the password file. When the password is not valid UTF-8 in Perl's internal representation, which for example happens with a password like 'ääääöööö', backing up a diskless VM would fail with: > Error: error building client for repository XXX - > PBS_PASSWORD contains bad characters and restoring would fail with: > restore failed: invalid utf-8 sequence of 1 bytes from index 0 This is fixed by properly encoding the value for the PBS_PASSWORD environment variable value again as UTF-8. Signed-off-by: Fiona Ebner --- Changes in v2: * Improve commit message - the ENV issues only happen when Perl's internal representation is not valid UTF-8 itself. src/PVE/QemuServer.pm | 4 ++++ src/PVE/VZDump/QemuServer.pm | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index 38f34f80..dbc5e5ea 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -5,6 +5,7 @@ use warnings; use Cwd 'abs_path'; use Digest::SHA; +use Encode qw(encode); use Fcntl ':flock'; use Fcntl; use File::Basename; @@ -6880,6 +6881,9 @@ sub restore_proxmox_backup_archive { # This is only used for `pbs-restore` and the QEMU PBS driver (live-restore) my $password = PVE::Storage::PBSPlugin::pbs_get_password($scfg, $storeid); + # The password is saved as UTF-8 and is decoded upon reading. Need to re-encode when setting the + # environment variable. + $password = encode('UTF-8', $password, 1); local $ENV{PBS_PASSWORD} = $password; local $ENV{PBS_FINGERPRINT} = $fingerprint if defined($fingerprint); diff --git a/src/PVE/VZDump/QemuServer.pm b/src/PVE/VZDump/QemuServer.pm index 55fb6dc4..afac1496 100644 --- a/src/PVE/VZDump/QemuServer.pm +++ b/src/PVE/VZDump/QemuServer.pm @@ -3,6 +3,7 @@ package PVE::VZDump::QemuServer; use strict; use warnings; +use Encode qw(encode); use Fcntl qw(:mode); use File::Basename; use File::Path qw(make_path remove_tree); @@ -738,6 +739,9 @@ sub archive_pbs { if (!$diskcount) { $self->loginfo("backup contains no disks"); + # The password is saved as UTF-8 and is decoded upon reading. Need to re-encode when setting + # the environment variable. + $password = encode('UTF-8', $password, 1); local $ENV{PBS_PASSWORD} = $password; local $ENV{PBS_FINGERPRINT} = $fingerprint if defined($fingerprint); my $cmd = [ -- 2.47.3