From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 34E8F1FF13E for ; Fri, 06 Mar 2026 15:34:48 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 004993648D; Fri, 6 Mar 2026 15:35:54 +0100 (CET) From: Shan Shaji To: pve-devel@lists.proxmox.com Subject: [PATCH proxmox_login_manager 1/1] cleanup: replace use of deprecated props and fix dart analyze issues Date: Fri, 6 Mar 2026 15:35:30 +0100 Message-ID: <20260306143530.113174-3-s.shaji@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260306143530.113174-1-s.shaji@proxmox.com> References: <20260306143530.113174-1-s.shaji@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1772807716398 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.114 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_SHORT 0.001 Use of a URL Shortener for very short URL RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: S2S6A5P6HDNYQFA76SYLVJBEPPHC4BM6 X-Message-ID-Hash: S2S6A5P6HDNYQFA76SYLVJBEPPHC4BM6 X-MailFrom: s.shaji@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: `value` property is deprecated in favor of `initialValue` starting from v3.35 [0]. Replaced the use of `value` prop with `initialValue`. Additionaly, removed the library name, as that is not necessary anymore [1]. [0] - https://docs.flutter.dev/release/breaking-changes/deprecate-dropdownbuttonformfield-value [1] - https://dart.dev/tools/linter-rules/unnecessary_library_name Signed-off-by: Shan Shaji --- lib/proxmox_login_form.dart | 2 +- lib/proxmox_login_manager.dart | 2 +- lib/proxmox_tfa_form.dart | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/proxmox_login_form.dart b/lib/proxmox_login_form.dart index b69636d..5b9a64e 100644 --- a/lib/proxmox_login_form.dart +++ b/lib/proxmox_login_form.dart @@ -125,7 +125,7 @@ class _ProxmoxLoginFormState extends State { onChanged: widget.onDomainChanged, selectedItemBuilder: (context) => widget.accessDomains!.map((e) => Text(e!.realm)).toList(), - value: widget.selectedDomain, + initialValue: widget.selectedDomain, ), Stack( children: [ diff --git a/lib/proxmox_login_manager.dart b/lib/proxmox_login_manager.dart index 8b09583..7868683 100644 --- a/lib/proxmox_login_manager.dart +++ b/lib/proxmox_login_manager.dart @@ -1,4 +1,4 @@ -library proxmox_login_manager; +library; export 'proxmox_login_selector.dart'; export 'proxmox_login_model.dart'; diff --git a/lib/proxmox_tfa_form.dart b/lib/proxmox_tfa_form.dart index ba18c54..79273fa 100644 --- a/lib/proxmox_tfa_form.dart +++ b/lib/proxmox_tfa_form.dart @@ -99,7 +99,7 @@ class _ProxmoxTfaFormState extends State { }, selectedItemBuilder: (context) => _tfaKinds.map((e) => Text(e)).toList(), - value: _selectedTfaKind, + initialValue: _selectedTfaKind, ), TextField( controller: _codeController, -- 2.47.3