From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 68EAF1FF13C for ; Thu, 05 Mar 2026 10:17:39 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BE7EA1EE4B; Thu, 5 Mar 2026 10:18:15 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Subject: [PATCH common 1/1] sysfs tools: remove moved code Date: Thu, 5 Mar 2026 10:16:57 +0100 Message-ID: <20260305091711.1221589-14-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260305091711.1221589-1-d.csapak@proxmox.com> References: <20260305091711.1221589-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.037 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 6RH7MQR3DG6E5NWSKDCNJ4YKEJNXBJV4 X-Message-ID-Hash: 6RH7MQR3DG6E5NWSKDCNJ4YKEJNXBJV4 X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: these functions now live in PVE::QemuServer::PCI::Mdev instead. Signed-off-by: Dominik Csapak --- src/PVE/SysFSTools.pm | 111 ------------------------------------------ 1 file changed, 111 deletions(-) diff --git a/src/PVE/SysFSTools.pm b/src/PVE/SysFSTools.pm index a00fbcb..f689a40 100644 --- a/src/PVE/SysFSTools.pm +++ b/src/PVE/SysFSTools.pm @@ -150,71 +150,6 @@ sub lspci { return $devices; } -# -# return format: -# [ -# { -# type => 'FooType_1', -# description => "a longer description with custom format\nand newlines", -# available => 5, -# }, -# ... -# ] -# -sub get_mdev_types { - my ($id) = @_; - - $id = normalize_pci_id($id); - - my $types = []; - - my $dev_path = "$pcisysfs/devices/$id"; - my $mdev_path = "$dev_path/mdev_supported_types"; - my $nvidia_path = "$dev_path/nvidia/creatable_vgpu_types"; - if (-d $mdev_path) { - dir_glob_foreach( - $mdev_path, - '[^\.].*', - sub { - my ($type) = @_; - - my $type_path = "$mdev_path/$type"; - - my $available = int(file_read_firstline("$type_path/available_instances")); - my $description = PVE::Tools::file_get_contents("$type_path/description"); - - my $entry = { - type => $type, - description => $description, - available => $available, - }; - - my $name = file_read_firstline("$type_path/name"); - $entry->{name} = $name if defined($name); - - push @$types, $entry; - }, - ); - } elsif (-f $nvidia_path) { - my $creatable = PVE::Tools::file_get_contents($nvidia_path); - for my $line (split("\n", $creatable)) { - next if $line =~ m/^ID/; # header - next if $line !~ m/^(.*?)\s*:\s*(.*)$/; - my $id = $1; - my $name = $2; - - push $types->@*, { - type => "nvidia-$id", # backwards compatibility - description => "", # TODO, read from xml/nvidia-smi ? - available => 1, - name => $name, - }; - } - } - - return $types; -} - sub check_iommu_support { # we have IOMMU support if /sys/class/iommu/ is populated return PVE::Tools::dir_glob_regex('/sys/class/iommu/', "[^\.].*"); @@ -372,52 +307,6 @@ sub pci_dev_group_bind_to_vfio { return 1; } -sub pci_create_mdev_device { - my ($pciid, $uuid, $type) = @_; - - $pciid = normalize_pci_id($pciid); - - my $basedir = "$pcisysfs/devices/$pciid"; - my $mdev_dir = "$basedir/mdev_supported_types"; - - die "pci device '$pciid' does not support mediated devices \n" - if !-d $mdev_dir; - - die "pci device '$pciid' has no type '$type'\n" - if !-d "$mdev_dir/$type"; - - if (-d "$basedir/$uuid") { - # it already exists, checking type - my $typelink = readlink("$basedir/$uuid/mdev_type"); - my ($existingtype) = $typelink =~ m|/([^/]+)$|; - die "mdev instance '$uuid' already exits, but type is not '$type'\n" - if $type ne $existingtype; - - # instance exists, so use it but warn the user - warn "mdev instance '$uuid' already existed, using it.\n"; - return undef; - } - - my $instances = file_read_firstline("$mdev_dir/$type/available_instances"); - my ($avail) = $instances =~ m/^(\d+)$/; - die "pci device '$pciid' has no available instances of '$type'\n" - if $avail < 1; - - die "could not create 'type' for pci devices '$pciid'\n" - if !file_write("$mdev_dir/$type/create", $uuid); - - return undef; -} - -# encode the hostpci index and vmid into the uuid -sub generate_mdev_uuid { - my ($vmid, $index) = @_; - - my $string = sprintf("%08d-0000-0000-0000-%012d", $index, $vmid); - - return $string; -} - # idea is from usbutils package (/usr/bin/usb-devices) script sub __scan_usb_device { my ($res, $devpath, $parent, $level) = @_; -- 2.47.3