From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 46A3E1FF138 for ; Wed, 04 Mar 2026 16:45:36 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2CAAEE2FF; Wed, 4 Mar 2026 16:46:28 +0100 (CET) From: Maximiliano Sandoval To: pve-devel@lists.proxmox.com Subject: [RFC PATCH storage 2/2] nfs: use rpcinfo as a showmounts fallback for nfs3 Date: Wed, 4 Mar 2026 16:45:49 +0100 Message-ID: <20260304154551.503663-3-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260304154551.503663-1-m.sandoval@proxmox.com> References: <20260304154551.503663-1-m.sandoval@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1772639126157 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.964 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.668 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.322 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1.141 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 7GGI2KM56DJI3SZA55PZH5FSO22XBD2Y X-Message-ID-Hash: 7GGI2KM56DJI3SZA55PZH5FSO22XBD2Y X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The check_connection call must succeed in order for the NFS storage to be activated. In a setup in which the NFS server does not list exports and which only supports NFSv3 this would result in the storage not being usable (not without manually mounting the NFS share and using the Directory storage instead). We add a fallback check with rpcinfo for this case. The rpcinfo check was replaced with showmounts in f8b0d82fe. At the time the rationale was that rpcinfo did not have support for ipv6 connections, which is not the case at the moment. In order to not break compatibility with setups that already activate correctly, we add a rpcinfo check as a fallback for NFSv3-only setups only after the showmounts command fails. Potential pitfalls: - Some NFSv3 servers might only support UDP [RFC 1813] - The two timeouts add up to 20 seconds which might be too much - Some NFS servers might not have rpcbind as described in acff89540 [RFC 1813]: https://datatracker.ietf.org/doc/html/rfc1813#section-2.3 Signed-off-by: Maximiliano Sandoval --- src/PVE/Storage/NFSPlugin.pm | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/PVE/Storage/NFSPlugin.pm b/src/PVE/Storage/NFSPlugin.pm index 062b3f32..3654e8b3 100644 --- a/src/PVE/Storage/NFSPlugin.pm +++ b/src/PVE/Storage/NFSPlugin.pm @@ -193,10 +193,12 @@ sub check_connection { my $cmd; + my $is_v3 = defined($opts) && $opts =~ /vers=3.*/; my $is_v4 = defined($opts) && $opts =~ /vers=4.*/; if ($is_v4) { $cmd = tcp_rpcinfo_cmd($server, '4'); } else { + # TODO Consider switching to rpcinfo altogether for Proxmox VE 10. $cmd = ['/sbin/showmount', '--no-headers', '--exports', $server]; } @@ -213,6 +215,12 @@ sub check_connection { return 0 if $port == 0; return PVE::Network::tcp_ping($server, $port, 2); + } elsif ($is_v3) { + $cmd = tcp_rpcinfo($server, '3'); + eval { + run_command($cmd, timeout => 10, outfunc => sub { }, errfunc => sub { }); + }; + return 1 if !$@; } return 0; } -- 2.47.3