From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id F1B081FF142 for ; Mon, 02 Mar 2026 15:46:21 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7E14237011; Mon, 2 Mar 2026 15:47:17 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Subject: [PATCH common v5 1/1] file: add exists and size helper Date: Mon, 2 Mar 2026 15:46:34 +0100 Message-ID: <20260302144642.3783463-2-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260302144642.3783463-1-d.csapak@proxmox.com> References: <20260302144642.3783463-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -1.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.012 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 1.188 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.93 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: KLYSNXJVLF4F7D7GYNYRKMFQAJEW3TAA X-Message-ID-Hash: KLYSNXJVLF4F7D7GYNYRKMFQAJEW3TAA X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Can be used by other modules that need easy mocking in tests. Signed-off-by: Dominik Csapak --- new in v5 (split out from first qemu-server patch) src/PVE/File.pm | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/src/PVE/File.pm b/src/PVE/File.pm index abdf9d7..3fa8643 100644 --- a/src/PVE/File.pm +++ b/src/PVE/File.pm @@ -13,8 +13,10 @@ use POSIX qw(EEXIST EOPNOTSUPP); use base 'Exporter'; our @EXPORT_OK = qw( + file_exists file_set_contents file_get_contents + file_get_size file_read_first_line file_read_last_line dir_glob_regex @@ -285,4 +287,16 @@ sub dir_glob_foreach($dir, $regex, $func) { } } +# easier to mock for testing than '-f'. +sub file_exists { + my ($path) = @_; + return -f $path; +} + +# easier to mock for testing than '-s'. +sub file_get_size { + my ($path) = @_; + return -s $path; +} + 1; -- 2.47.3