From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 046B11FF13F for ; Thu, 26 Feb 2026 15:43:00 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1DA7B346F0; Thu, 26 Feb 2026 15:43:55 +0100 (CET) From: Maximiliano Sandoval To: pve-devel@lists.proxmox.com Subject: [PATCH storage 1/1] cifs: match smbversion description with docs Date: Thu, 26 Feb 2026 15:43:14 +0100 Message-ID: <20260226144316.451521-2-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260226144316.451521-1-m.sandoval@proxmox.com> References: <20260226144316.451521-1-m.sandoval@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1772116978724 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.094 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ROB6ZE6ID5C5EWMHGAFQ63PBZ676WJZ2 X-Message-ID-Hash: ROB6ZE6ID5C5EWMHGAFQ63PBZ676WJZ2 X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Signed-off-by: Maximiliano Sandoval --- src/PVE/Storage/CIFSPlugin.pm | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/PVE/Storage/CIFSPlugin.pm b/src/PVE/Storage/CIFSPlugin.pm index 54f0f4e..665ce1f 100644 --- a/src/PVE/Storage/CIFSPlugin.pm +++ b/src/PVE/Storage/CIFSPlugin.pm @@ -147,9 +147,10 @@ sub properties { maxLength => 256, }, smbversion => { - description => - "SMB protocol version. 'default' if not set, negotiates the highest SMB2+" - . " version supported by both the client and server.", + description => "SMB protocol version.", + verbose_description => "SMB protocol version. When set to `default` or when unset," + . " negotiates the highest SMB2+ version supported by both the client and server." + . " SMB1 is not supported due to security issues.", type => 'string', default => 'default', enum => ['default', '2.0', '2.1', '3', '3.0', '3.11'], -- 2.47.3