From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 0447D1FF13B for ; Wed, 25 Feb 2026 16:46:17 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0388DA92D; Wed, 25 Feb 2026 16:46:55 +0100 (CET) From: Maximiliano Sandoval To: pve-devel@lists.proxmox.com Subject: [PATCH manager 5/7] ui: qga: add checkbox for guest-fsfreeze Date: Wed, 25 Feb 2026 16:45:44 +0100 Message-ID: <20260225154614.681858-6-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260225154614.681858-1-m.sandoval@proxmox.com> References: <20260225154614.681858-1-m.sandoval@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1772034357663 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.091 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 7DDGL3SPZZNXFNCR32YZPP4JYHGQ3IWP X-Message-ID-Hash: 7DDGL3SPZZNXFNCR32YZPP4JYHGQ3IWP X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: We re-use the same components from the 'freeze-fs-on-backup' checkbox but without referencing that this only affects backups. Signed-off-by: Maximiliano Sandoval --- www/manager6/form/AgentFeatureSelector.js | 28 +++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/www/manager6/form/AgentFeatureSelector.js b/www/manager6/form/AgentFeatureSelector.js index e7fa929c..a3dda630 100644 --- a/www/manager6/form/AgentFeatureSelector.js +++ b/www/manager6/form/AgentFeatureSelector.js @@ -21,6 +21,28 @@ Ext.define('PVE.form.AgentFeatureSelector', { }, disabled: true, }, + { + xtype: 'proxmoxcheckbox', + boxLabel: gettext('Freeze/thaw guest filesystems for consistency'), + name: 'guest-fsfreeze', + reference: 'guest_fsfreeze', + bind: { + disabled: '{!enabled.checked}', + }, + disabled: true, + uncheckedValue: '0', + defaultValue: '1', + }, + { + xtype: 'displayfield', + userCls: 'pmx-hint', + value: gettext( + 'Freeze/thaw for guest filesystems disabled. This can lead to inconsistent disk images.', + ), + bind: { + hidden: '{guest_fsfreeze.checked}', + }, + }, { xtype: 'displayfield', userCls: 'pmx-hint', @@ -73,6 +95,9 @@ Ext.define('PVE.form.AgentFeatureSelector', { if (PVE.Parser.parseBoolean(values['freeze-fs-on-backup'])) { delete values['freeze-fs-on-backup']; } + if (PVE.Parser.parseBoolean(values['guest-fsfreeze'])) { + delete values['guest-fsfreeze']; + } const agentstr = PVE.Parser.printPropertyString(values, 'enabled'); return { agent: agentstr }; @@ -83,6 +108,9 @@ Ext.define('PVE.form.AgentFeatureSelector', { if (!Ext.isDefined(res['freeze-fs-on-backup'])) { res['freeze-fs-on-backup'] = 1; } + if (!Ext.isDefined(res['guest-fsfreeze'])) { + res['guest-fsfreeze'] = 1; + } this.callParent([res]); }, -- 2.47.3