From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 08EEC1FF136 for ; Mon, 23 Feb 2026 16:25:17 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 906F610B2B; Mon, 23 Feb 2026 16:26:05 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server v4 3/6] apply pending: efi disk: print drive to pick up changes Date: Mon, 23 Feb 2026 16:25:35 +0100 Message-ID: <20260223152556.197761-4-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260223152556.197761-1-f.ebner@proxmox.com> References: <20260223152556.197761-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771860345387 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.081 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.798 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.79 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.547 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: WQJ4ONEBIVMWXLBJV6AQFANNCXKNUIRP X-Message-ID-Hash: WQJ4ONEBIVMWXLBJV6AQFANNCXKNUIRP X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: When setting 'ms-cert=2023' rather than 'ms-cert=2023w' on an existing EFI disk, both certificates would still be enrolled, but the 'ms-cert=2023' would end up in the VM configuration. Pick up the 'ms-cert=2023w' marker which already gets set by the OVMF::change_drive() function. Reported-by: Daniel Kral Signed-off-by: Fiona Ebner --- New in v4. src/PVE/QemuServer.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index d103731c..741b2499 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -4972,6 +4972,7 @@ sub vmconfig_apply_pending { $old_drive, $new_drive, ); + $conf->{pending}->{$opt} = print_drive($new_drive); } } elsif (defined($conf->{pending}->{$opt}) && $opt =~ m/^net\d+$/) { my $new_net = PVE::QemuServer::Network::parse_net($conf->{pending}->{$opt}); -- 2.47.3