From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 41EAC1FF136 for ; Mon, 23 Feb 2026 16:25:22 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BE60610CCE; Mon, 23 Feb 2026 16:26:06 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server v4 2/6] efi disk: clarify that there are multiple certificates Date: Mon, 23 Feb 2026 16:25:34 +0100 Message-ID: <20260223152556.197761-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260223152556.197761-1-f.ebner@proxmox.com> References: <20260223152556.197761-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771860345331 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.081 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.798 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.79 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.547 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: RQT6YWTT7C24SDO3UO67EEEOD4OJHLAI X-Message-ID-Hash: RQT6YWTT7C24SDO3UO67EEEOD4OJHLAI X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Suggested-by: Daniel Kral Signed-off-by: Fiona Ebner --- New in v4. src/PVE/CLI/qm.pm | 3 ++- src/PVE/QemuServer.pm | 11 ++++++----- src/PVE/QemuServer/Drive.pm | 4 ++-- 3 files changed, 10 insertions(+), 8 deletions(-) diff --git a/src/PVE/CLI/qm.pm b/src/PVE/CLI/qm.pm index 5326db5f..f1867337 100755 --- a/src/PVE/CLI/qm.pm +++ b/src/PVE/CLI/qm.pm @@ -700,7 +700,8 @@ __PACKAGE__->register_method({ method => 'POST', description => "Enroll important updated certificates to the EFI disk with pre-enrolled-keys. Currently," - . " this is only the Microsoft UEFI CA 2023. Must be called while the VM is shut down.", + . " these are UEFI 2023 certificates from Microsoft. Must be called while the VM is shut" + . " down.", parameters => { additionalProperties => 0, properties => { diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index 03354e31..d103731c 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -5406,11 +5406,12 @@ my sub check_efi_vars { my $efidisk = parse_drive('efidisk0', $conf->{efidisk0}); if (PVE::QemuServer::OVMF::should_enroll_ms_2023_cert($efidisk)) { # TODO: make the first print a log_warn with PVE 9.2 to make it more noticeable! - print "EFI disk without 'ms-cert=2023w' option, suggesting that the Microsoft UEFI 2023\n"; - print "certificate is not enrolled yet. The UEFI 2011 certificate expires in June 2026!\n"; - print "The new certificate is required for secure boot update for Windows and common\n"; - print "Linux distributions. Use 'Disk Action > Enroll Updated Certificates' in the UI\n"; - print "or, while the VM is shut down, run 'qm enroll-efi-keys $vmid' to enroll it.\n\n"; + print "EFI disk without 'ms-cert=2023w' option, suggesting that not all UEFI 2023\n"; + print "certificates from Microsoft are enrolled yet. The UEFI 2011 certificates expire\n"; + print "in June 2026! The new certificate are required for secure boot update for Windows\n"; + print "and common Linux distributions. Use 'Disk Action > Enroll Updated Certificates'\n"; + print "in the UI or, while the VM is shut down, run 'qm enroll-efi-keys $vmid' to enroll\n"; + print "the new certificates.\n\n"; print "For Windows with BitLocker, run the following command inside Powershell:\n"; print " manage-bde -protectors -disable \n"; print "for each drive with BitLocker (for example, could be 'C:').\n"; diff --git a/src/PVE/QemuServer/Drive.pm b/src/PVE/QemuServer/Drive.pm index ae907b5c..fa70ee6b 100644 --- a/src/PVE/QemuServer/Drive.pm +++ b/src/PVE/QemuServer/Drive.pm @@ -525,8 +525,8 @@ my %efitype_fmt = ( type => 'string', enum => [qw(2011 2023 2023w)], description => - "Informational marker indicating the version of the latest Microsoft UEFI certificate" - . " that has been enrolled by Proxmox VE. The value '2023w' means that both the" + "Informational marker indicating the version of the latest Microsoft UEFI certificates" + . " that have been enrolled by Proxmox VE. The value '2023w' means that both the" . " 'Microsoft UEFI CA 2023' and the 'Windows UEFI CA 2023' certificates are included." . " The value '2023' is deprecated and for compatibility only.", optional => 1, -- 2.47.3