From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 99A3B1FF13C for ; Thu, 19 Feb 2026 15:56:42 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 157FB1883B; Thu, 19 Feb 2026 15:57:11 +0100 (CET) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager 04/11] ui: fabrics: split node selector creation and config Date: Thu, 19 Feb 2026 15:56:37 +0100 Message-ID: <20260219145649.441418-21-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260219145649.441418-1-s.hanreich@proxmox.com> References: <20260219145649.441418-1-s.hanreich@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.176 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: 4FVJ3WUIS6PQOTMJMEF7H52GRZBQQH4H X-Message-ID-Hash: 4FVJ3WUIS6PQOTMJMEF7H52GRZBQQH4H X-MailFrom: hoan@cray.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This allows for overriding the configuration of the node selector, before it is created. This avoids running into potential race conditions when adding listeners on load events, which could complete after the component has been created, but before a child component has attached its listener. Signed-off-by: Stefan Hanreich --- www/manager6/sdn/fabrics/NodeEdit.js | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/www/manager6/sdn/fabrics/NodeEdit.js b/www/manager6/sdn/fabrics/NodeEdit.js index dd8ad0274..b3d9751aa 100644 --- a/www/manager6/sdn/fabrics/NodeEdit.js +++ b/www/manager6/sdn/fabrics/NodeEdit.js @@ -136,10 +136,10 @@ Ext.define('PVE.sdn.Fabric.Node.Edit', { }); }, - getNodeSelector: function () { + getNodeSelectorConfig: function() { let me = this; - return Ext.create('PVE.form.NodeSelector', { + return { xtype: 'pveNodeSelector', reference: 'nodeselector', fieldLabel: gettext('Node'), @@ -193,7 +193,12 @@ Ext.define('PVE.sdn.Fabric.Node.Edit', { }, }, }, - }); + }; + }, + + getNodeSelector: function () { + let me = this; + return Ext.create('PVE.form.NodeSelector', me.getNodeSelectorConfig()); }, getInterfacePanel: function (protocol) { -- 2.47.3