From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 205281FF13C for ; Thu, 19 Feb 2026 15:55:53 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C9FAA17F15; Thu, 19 Feb 2026 15:56:53 +0100 (CET) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Subject: [PATCH proxmox 1/2] wireguard: skip serializing preshared_key if unset Date: Thu, 19 Feb 2026 15:56:18 +0100 Message-ID: <20260219145649.441418-2-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260219145649.441418-1-s.hanreich@proxmox.com> References: <20260219145649.441418-1-s.hanreich@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.177 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: CJBU3TTLNRGDF3PGNXGT3ZGG4UMUWWHL X-Message-ID-Hash: CJBU3TTLNRGDF3PGNXGT3ZGG4UMUWWHL X-MailFrom: hoan@cray.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Otherwise the generated WireGuard configuration is invalid, because it contains a line 'PresharedKey=', which trips up wg(8). Avoid this by skipping serialization for unset preshared keys. Signed-off-by: Stefan Hanreich --- proxmox-wireguard/src/lib.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/proxmox-wireguard/src/lib.rs b/proxmox-wireguard/src/lib.rs index 593713d8..41a2922d 100644 --- a/proxmox-wireguard/src/lib.rs +++ b/proxmox-wireguard/src/lib.rs @@ -155,6 +155,7 @@ pub struct WireGuardPeer { /// Additional key preshared between two peers. Adds an additional layer of symmetric-key /// cryptography to be mixed into the already existing public-key cryptography, for /// post-quantum resistance. + #[serde(skip_serializing_if = "Option::is_none")] pub preshared_key: Option, /// List of IPv4/v6 CIDRs from which incoming traffic for this peer is allowed and to which /// outgoing traffic for this peer is directed. The catch-all 0.0.0.0/0 may be specified for -- 2.47.3