From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id D42801FF137 for ; Tue, 17 Feb 2026 15:14:18 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 368962318; Tue, 17 Feb 2026 15:14:56 +0100 (CET) From: Daniel Kral To: pve-devel@lists.proxmox.com Subject: [RFC ha-manager 02/21] resources: remove redundant load_config fallback for static config Date: Tue, 17 Feb 2026 15:14:09 +0100 Message-ID: <20260217141437.584852-16-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260217141437.584852-1-d.kral@proxmox.com> References: <20260217141437.584852-1-d.kral@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771337677056 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.019 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: FCZXB4UFIQQAVYVIAZWVU2YJTHELNOCV X-Message-ID-Hash: FCZXB4UFIQQAVYVIAZWVU2YJTHELNOCV X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The return value of get_static_service_stats(...) is fetched through PVE::Cluster::get_guest_config_properties(...), which in turn reads all guest configuration files with a memdb_read_nolock(...) in the pmxcfs. As PVE::AbstractConfig::load_config(...) internally gets the content of the guest configuration file through cfs_read_file(...), which in turn receives the return value of the equivalent memdb_read(...) from a CFS_IPC_GET_CONFIG message, the fallback is likely to fail as well. Signed-off-by: Daniel Kral --- src/PVE/HA/Resources/PVECT.pm | 1 - src/PVE/HA/Resources/PVEVM.pm | 1 - 2 files changed, 2 deletions(-) diff --git a/src/PVE/HA/Resources/PVECT.pm b/src/PVE/HA/Resources/PVECT.pm index 4cbf6db3..b9ce2ac3 100644 --- a/src/PVE/HA/Resources/PVECT.pm +++ b/src/PVE/HA/Resources/PVECT.pm @@ -163,7 +163,6 @@ sub get_static_stats { my ($class, $haenv, $id, $service_node) = @_; my $conf = $haenv->get_static_service_stats($id); - $conf = PVE::LXC::Config->load_config($id, $service_node) if !defined($conf); return { maxcpu => PVE::LXC::Config->get_derived_property($conf, 'max-cpu'), diff --git a/src/PVE/HA/Resources/PVEVM.pm b/src/PVE/HA/Resources/PVEVM.pm index 7586da84..303334ba 100644 --- a/src/PVE/HA/Resources/PVEVM.pm +++ b/src/PVE/HA/Resources/PVEVM.pm @@ -184,7 +184,6 @@ sub get_static_stats { my ($class, $haenv, $id, $service_node) = @_; my $conf = $haenv->get_static_service_stats($id); - $conf = PVE::QemuConfig->load_config($id, $service_node) if !defined($conf); return { maxcpu => PVE::QemuConfig->get_derived_property($conf, 'max-cpu'), -- 2.47.3