From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E1F4C1FF142 for ; Mon, 16 Feb 2026 11:45:40 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 94E6EDAA0; Mon, 16 Feb 2026 11:45:11 +0100 (CET) From: Dietmar Maurer To: pve-devel@lists.proxmox.com Subject: [RFC proxmox 08/22] firewall-api-types: add FirewallNodeOptions struct Date: Mon, 16 Feb 2026 11:43:46 +0100 Message-ID: <20260216104401.3959270-9-dietmar@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260216104401.3959270-1-dietmar@proxmox.com> References: <20260216104401.3959270-1-dietmar@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.570 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: M7NNEDBZA2NCFPFFBSNEYUY3JNYSB4J5 X-Message-ID-Hash: M7NNEDBZA2NCFPFFBSNEYUY3JNYSB4J5 X-MailFrom: dietmar@zilli.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Adds the FirewallNodeOptions struct for node-level firewall configuration, including settings for host firewall enablement, conntrack parameters, NDP, synflood protection, SMURF filter, TCP flags, and various log level options. Uses perl-compatible deserialization for boolean/numeric fields. Extracted form perl api, but replaced Vec with new > helper type. Signed-off-by: Dietmar Maurer --- proxmox-firewall-api-types/src/lib.rs | 3 + .../src/node_options.rs | 240 ++++++++++++++++++ 2 files changed, 243 insertions(+) create mode 100644 proxmox-firewall-api-types/src/node_options.rs diff --git a/proxmox-firewall-api-types/src/lib.rs b/proxmox-firewall-api-types/src/lib.rs index c6fc9ebb..ef672bfe 100644 --- a/proxmox-firewall-api-types/src/lib.rs +++ b/proxmox-firewall-api-types/src/lib.rs @@ -14,3 +14,6 @@ pub use cluster_options::FirewallClusterOptions; mod guest_options; pub use guest_options::FirewallGuestOptions; + +mod node_options; +pub use node_options::FirewallNodeOptions; diff --git a/proxmox-firewall-api-types/src/node_options.rs b/proxmox-firewall-api-types/src/node_options.rs new file mode 100644 index 00000000..b7873904 --- /dev/null +++ b/proxmox-firewall-api-types/src/node_options.rs @@ -0,0 +1,240 @@ +use super::{FirewallConntrackHelper, FirewallLogLevel}; +use proxmox_schema::api; +use proxmox_schema::comma_separated_list::CommaSeparatedList; + +#[api( + properties: { + enable: { + default: true, + optional: true, + }, + log_level_forward: { + optional: true, + type: FirewallLogLevel, + }, + log_level_in: { + optional: true, + type: FirewallLogLevel, + }, + log_level_out: { + optional: true, + type: FirewallLogLevel, + }, + log_nf_conntrack: { + default: false, + optional: true, + }, + ndp: { + default: true, + optional: true, + }, + nf_conntrack_allow_invalid: { + default: false, + optional: true, + }, + nf_conntrack_helpers: { + optional: true, + }, + nf_conntrack_max: { + default: 262144, + minimum: 32768, + optional: true, + type: Integer, + }, + nf_conntrack_tcp_timeout_established: { + default: 432000, + minimum: 7875, + optional: true, + type: Integer, + }, + nf_conntrack_tcp_timeout_syn_recv: { + default: 60, + maximum: 60, + minimum: 30, + optional: true, + type: Integer, + }, + nftables: { + default: false, + optional: true, + }, + nosmurfs: { + default: false, + optional: true, + }, + protection_synflood: { + default: false, + optional: true, + }, + protection_synflood_burst: { + default: 1000, + optional: true, + type: Integer, + }, + protection_synflood_rate: { + default: 200, + optional: true, + type: Integer, + }, + smurf_log_level: { + optional: true, + type: FirewallLogLevel, + }, + tcp_flags_log_level: { + optional: true, + type: FirewallLogLevel, + }, + tcpflags: { + default: false, + optional: true, + }, + }, +)] +/// Node Firewall Options +#[derive(Debug, serde::Deserialize, serde::Serialize)] +pub struct FirewallNodeOptions { + /// Enable host firewall rules. + #[serde(deserialize_with = "proxmox_serde::perl::deserialize_bool")] + #[serde(default, skip_serializing_if = "Option::is_none")] + pub enable: Option, + + #[serde(default, skip_serializing_if = "Option::is_none")] + pub log_level_forward: Option, + + #[serde(default, skip_serializing_if = "Option::is_none")] + pub log_level_in: Option, + + #[serde(default, skip_serializing_if = "Option::is_none")] + pub log_level_out: Option, + + /// Enable logging of conntrack information. + #[serde(deserialize_with = "proxmox_serde::perl::deserialize_bool")] + #[serde(default, skip_serializing_if = "Option::is_none")] + pub log_nf_conntrack: Option, + + /// Enable NDP (Neighbor Discovery Protocol). + #[serde(deserialize_with = "proxmox_serde::perl::deserialize_bool")] + #[serde(default, skip_serializing_if = "Option::is_none")] + pub ndp: Option, + + /// Allow invalid packets on connection tracking. + #[serde(deserialize_with = "proxmox_serde::perl::deserialize_bool")] + #[serde(default, skip_serializing_if = "Option::is_none")] + pub nf_conntrack_allow_invalid: Option, + + /// Enable conntrack helpers for specific protocols. Supported protocols: + /// amanda, ftp, irc, netbios-ns, pptp, sane, sip, snmp, tftp + #[serde(default, skip_serializing_if = "Option::is_none")] + pub nf_conntrack_helpers: Option>, + + /// Maximum number of tracked connections. + #[serde(deserialize_with = "proxmox_serde::perl::deserialize_u64")] + #[serde(default, skip_serializing_if = "Option::is_none")] + pub nf_conntrack_max: Option, + + /// Conntrack established timeout. + #[serde(deserialize_with = "proxmox_serde::perl::deserialize_u64")] + #[serde(default, skip_serializing_if = "Option::is_none")] + pub nf_conntrack_tcp_timeout_established: Option, + + /// Conntrack syn recv timeout. + #[serde(deserialize_with = "proxmox_serde::perl::deserialize_u8")] + #[serde(default, skip_serializing_if = "Option::is_none")] + pub nf_conntrack_tcp_timeout_syn_recv: Option, + + /// Enable nftables based firewall (tech preview) + #[serde(deserialize_with = "proxmox_serde::perl::deserialize_bool")] + #[serde(default, skip_serializing_if = "Option::is_none")] + pub nftables: Option, + + /// Enable SMURFS filter. + #[serde(deserialize_with = "proxmox_serde::perl::deserialize_bool")] + #[serde(default, skip_serializing_if = "Option::is_none")] + pub nosmurfs: Option, + + /// Enable synflood protection + #[serde(deserialize_with = "proxmox_serde::perl::deserialize_bool")] + #[serde(default, skip_serializing_if = "Option::is_none")] + pub protection_synflood: Option, + + /// Synflood protection rate burst by ip src. + #[serde(deserialize_with = "proxmox_serde::perl::deserialize_i64")] + #[serde(default, skip_serializing_if = "Option::is_none")] + pub protection_synflood_burst: Option, + + /// Synflood protection rate syn/sec by ip src. + #[serde(deserialize_with = "proxmox_serde::perl::deserialize_i64")] + #[serde(default, skip_serializing_if = "Option::is_none")] + pub protection_synflood_rate: Option, + + #[serde(default, skip_serializing_if = "Option::is_none")] + pub smurf_log_level: Option, + + #[serde(default, skip_serializing_if = "Option::is_none")] + pub tcp_flags_log_level: Option, + + /// Filter illegal combinations of TCP flags. + #[serde(deserialize_with = "proxmox_serde::perl::deserialize_bool")] + #[serde(default, skip_serializing_if = "Option::is_none")] + pub tcpflags: Option, +} + +#[cfg(test)] +mod tests { + use super::*; + + #[test] + fn test_conntrack_list() { + let ok_tests = vec![ + ("", None, ""), + ( + "ftp", + Some(CommaSeparatedList::new(vec![FirewallConntrackHelper::Ftp])), + "ftp", + ), + ( + "ftp,pptp", + Some(CommaSeparatedList::new(vec![ + FirewallConntrackHelper::Ftp, + FirewallConntrackHelper::Pptp, + ])), + "ftp,pptp", + ), + ( + ",,ftp;pptp;;;", + Some(CommaSeparatedList::new(vec![ + FirewallConntrackHelper::Ftp, + FirewallConntrackHelper::Pptp, + ])), + "ftp,pptp", + ), + ( + "ftp\0pptp\0", + Some(CommaSeparatedList::new(vec![ + FirewallConntrackHelper::Ftp, + FirewallConntrackHelper::Pptp, + ])), + "ftp,pptp", + ), + ]; + + for (input, expected, expected_str) in ok_tests { + let helpers: Option> = + serde_plain::from_str(input).unwrap(); + assert_eq!(helpers, expected); + assert_eq!(serde_plain::to_string(&helpers).unwrap(), expected_str); + } + } + + #[test] + #[cfg(not(feature = "enum-fallback"))] + fn test_conntrack_list_unknown() { + let err_tests = vec!["unknown", "ftp,Unknown", "ftp,pptp,un-known"]; + + for input in err_tests { + let helpers: Result>, _> = + serde_plain::from_str(input); + assert!(helpers.is_err()); + } + } +} -- 2.47.3