From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id EFDA41FF142 for ; Mon, 16 Feb 2026 11:44:00 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B18B3C711; Mon, 16 Feb 2026 11:44:32 +0100 (CET) From: Dietmar Maurer To: pve-devel@lists.proxmox.com Subject: [RFC proxmox 07/22] firewall-api-types: add FirewallConntrackHelper enum Date: Mon, 16 Feb 2026 11:43:45 +0100 Message-ID: <20260216104401.3959270-8-dietmar@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260216104401.3959270-1-dietmar@proxmox.com> References: <20260216104401.3959270-1-dietmar@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.574 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: G4VRER6F7W5RT2SLIKGHEHKSGRF72PC5 X-Message-ID-Hash: G4VRER6F7W5RT2SLIKGHEHKSGRF72PC5 X-MailFrom: dietmar@zilli.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Adds an enum for supported conntrack helpers (amanda, ftp, irc, netbios-ns, pptp, sane, sip, snmp, tftp). Implements CommaSeparatedListSchema to allow usage with CommaSeparatedList. Extracted form perl api and added "enum-fallback" feature. Signed-off-by: Dietmar Maurer --- proxmox-firewall-api-types/src/conntrack.rs | 52 +++++++++++++++++++++ proxmox-firewall-api-types/src/lib.rs | 3 ++ 2 files changed, 55 insertions(+) create mode 100644 proxmox-firewall-api-types/src/conntrack.rs diff --git a/proxmox-firewall-api-types/src/conntrack.rs b/proxmox-firewall-api-types/src/conntrack.rs new file mode 100644 index 00000000..278ec2ad --- /dev/null +++ b/proxmox-firewall-api-types/src/conntrack.rs @@ -0,0 +1,52 @@ +#[cfg(feature = "enum-fallback")] +use proxmox_fixed_string::FixedString; +use proxmox_schema::comma_separated_list::CommaSeparatedListSchema; +use proxmox_schema::{api, ApiType, Schema}; + +#[api] +/// Firewall conntrack helper. +#[derive(Clone, Copy, Debug, Eq, PartialEq, serde::Deserialize, serde::Serialize)] +pub enum FirewallConntrackHelper { + #[serde(rename = "amanda")] + /// amanda. + Amanda, + #[serde(rename = "ftp")] + /// ftp. + Ftp, + #[serde(rename = "irc")] + /// irc. + Irc, + #[serde(rename = "netbios-ns")] + /// netbios-ns. + NetbiosNs, + #[serde(rename = "pptp")] + /// pptp. + Pptp, + #[serde(rename = "sane")] + /// sane. + Sane, + #[serde(rename = "sip")] + /// sip. + Sip, + #[serde(rename = "snmp")] + /// snmp. + Snmp, + #[serde(rename = "tftp")] + /// tftp. + Tftp, + #[cfg(feature = "enum-fallback")] + /// Unknown variants for forward compatibility. + #[serde(untagged)] + UnknownEnumValue(FixedString), +} +serde_plain::derive_display_from_serialize!(FirewallConntrackHelper); +serde_plain::derive_fromstr_from_deserialize!(FirewallConntrackHelper); + +// So that we can use CommaSeparatedList +impl CommaSeparatedListSchema for FirewallConntrackHelper { + const ARRAY_SCHEMA: Schema = proxmox_schema::ArraySchema::new( + "Array of firewall conntrack helper names.", + &FirewallConntrackHelper::API_SCHEMA, + ) + .schema(); +} diff --git a/proxmox-firewall-api-types/src/lib.rs b/proxmox-firewall-api-types/src/lib.rs index c66262cc..c6fc9ebb 100644 --- a/proxmox-firewall-api-types/src/lib.rs +++ b/proxmox-firewall-api-types/src/lib.rs @@ -1,3 +1,6 @@ +mod conntrack; +pub use conntrack::FirewallConntrackHelper; + mod log; pub use log::{ FirewallLogLevel, FirewallLogRateLimit, FirewallPacketRate, FirewallPacketRateTimescale, -- 2.47.3