From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 2EDEA1FF142 for ; Mon, 16 Feb 2026 11:50:05 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E527BE4CE; Mon, 16 Feb 2026 11:50:51 +0100 (CET) From: Dietmar Maurer To: pve-devel@lists.proxmox.com Subject: [RFC proxmox 16/22] firewall-api-types: use ConfigDigest from proxmox-config-digest crate Date: Mon, 16 Feb 2026 11:43:54 +0100 Message-ID: <20260216104401.3959270-17-dietmar@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260216104401.3959270-1-dietmar@proxmox.com> References: <20260216104401.3959270-1-dietmar@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.565 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: SH2PKPIUU5W45TCYFV66N6W5OXODTGJQ X-Message-ID-Hash: SH2PKPIUU5W45TCYFV66N6W5OXODTGJQ X-MailFrom: dietmar@zilli.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Signed-off-by: Dietmar Maurer --- proxmox-firewall-api-types/Cargo.toml | 1 + proxmox-firewall-api-types/src/rule.rs | 5 ++--- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/proxmox-firewall-api-types/Cargo.toml b/proxmox-firewall-api-types/Cargo.toml index 8b77b522..2e894606 100644 --- a/proxmox-firewall-api-types/Cargo.toml +++ b/proxmox-firewall-api-types/Cargo.toml @@ -23,3 +23,4 @@ proxmox-schema = { workspace = true, features = ["api-macro"] } proxmox-serde = { workspace = true, features = ["perl"] } proxmox-fixed-string = { workspace = true, optional = true } proxmox-network-types = { workspace = true, features = [ "api-types" ] } +proxmox-config-digest = { workspace = true } \ No newline at end of file diff --git a/proxmox-firewall-api-types/src/rule.rs b/proxmox-firewall-api-types/src/rule.rs index a2298609..835ac96e 100644 --- a/proxmox-firewall-api-types/src/rule.rs +++ b/proxmox-firewall-api-types/src/rule.rs @@ -1,3 +1,4 @@ +use proxmox_config_digest::ConfigDigest; use serde::{Deserialize, Serialize}; #[cfg(feature = "enum-fallback")] @@ -29,9 +30,7 @@ const_regex! { optional: true, }, digest: { - max_length: 64, optional: true, - type: String, }, dport: { optional: true, @@ -98,7 +97,7 @@ pub struct FirewallRule { /// Prevent changes if current configuration file has a different digest. /// This can be used to prevent concurrent modifications. #[serde(default, skip_serializing_if = "Option::is_none")] - pub digest: Option, + pub digest: Option, /// Restrict TCP/UDP destination port. #[serde(default, skip_serializing_if = "Option::is_none")] -- 2.47.3