From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id EABD01FF141 for ; Fri, 13 Feb 2026 17:04:31 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4D9349AF1; Fri, 13 Feb 2026 17:04:37 +0100 (CET) From: Arthur Bied-Charreton To: pve-devel@lists.proxmox.com Subject: [PATCH proxmox-perl-rs 1/1] notify (smtp): add oauth2 parameters to bindings Date: Fri, 13 Feb 2026 17:04:06 +0100 Message-ID: <20260213160415.609868-9-a.bied-charreton@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260213160415.609868-1-a.bied-charreton@proxmox.com> References: <20260213160415.609868-1-a.bied-charreton@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.081 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: UU4UK4F4IIILKWVXKZV2HUWBIZODT7WG X-Message-ID-Hash: UU4UK4F4IIILKWVXKZV2HUWBIZODT7WG X-MailFrom: abied-charreton@jett.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Update SMTP bindings to take the Smtp(Private)?Config structs directly, and additionally the OAuth2 refresh token. Signed-off-by: Arthur Bied-Charreton --- common/src/bindings/notify.rs | 82 ++++++++++++----------------------- 1 file changed, 28 insertions(+), 54 deletions(-) diff --git a/common/src/bindings/notify.rs b/common/src/bindings/notify.rs index 409270a..137cc79 100644 --- a/common/src/bindings/notify.rs +++ b/common/src/bindings/notify.rs @@ -12,7 +12,7 @@ pub mod proxmox_rs_notify { use std::collections::HashMap; use std::sync::Mutex; - use anyhow::{Error, bail}; + use anyhow::{bail, Error}; use serde_json::Value as JSONValue; use perlmod::Value; @@ -26,7 +26,7 @@ pub mod proxmox_rs_notify { DeleteableSendmailProperty, SendmailConfig, SendmailConfigUpdater, }; use proxmox_notify::endpoints::smtp::{ - DeleteableSmtpProperty, SmtpConfig, SmtpConfigUpdater, SmtpMode, SmtpPrivateConfig, + DeleteableSmtpProperty, SmtpConfig, SmtpConfigUpdater, SmtpPrivateConfig, SmtpPrivateConfigUpdater, }; use proxmox_notify::endpoints::webhook::{ @@ -36,7 +36,7 @@ pub mod proxmox_rs_notify { CalendarMatcher, DeleteableMatcherProperty, FieldMatcher, MatchModeOperator, MatcherConfig, MatcherConfigUpdater, SeverityMatcher, }; - use proxmox_notify::{Config, Notification, Severity, api}; + use proxmox_notify::{api, Config, Notification, Severity}; /// A notification catalog instance. /// @@ -141,6 +141,19 @@ pub mod proxmox_rs_notify { api::common::send(&config, ¬ification) } + /// Method: Refresh the state for all endpoints. + /// + /// This iterates through all configured targets, refreshing their state if needed. + /// + /// See [`api::common::refresh_targets`] + #[export(serialize_error)] + pub fn trigger_state_refresh( + #[try_from_ref] this: &NotificationConfig, + ) -> Result<(), HttpError> { + let config = this.config.lock().unwrap(); + api::common::trigger_state_refresh(&config) + } + /// Method: Get a list of all notification targets. /// /// See [`api::get_targets`]. @@ -390,37 +403,16 @@ pub mod proxmox_rs_notify { #[allow(clippy::too_many_arguments)] pub fn add_smtp_endpoint( #[try_from_ref] this: &NotificationConfig, - name: String, - server: String, - port: Option, - mode: Option, - username: Option, - password: Option, - mailto: Option>, - mailto_user: Option>, - from_address: String, - author: Option, - comment: Option, - disable: Option, + smtp_config: SmtpConfig, + smtp_private_config: SmtpPrivateConfig, + oauth2_refresh_token: Option, ) -> Result<(), HttpError> { let mut config = this.config.lock().unwrap(); api::smtp::add_endpoint( &mut config, - SmtpConfig { - name: name.clone(), - server, - port, - mode, - username, - mailto: mailto.unwrap_or_default(), - mailto_user: mailto_user.unwrap_or_default(), - from_address, - author, - comment, - disable, - origin: None, - }, - SmtpPrivateConfig { name, password }, + smtp_config, + smtp_private_config, + oauth2_refresh_token, ) } @@ -432,17 +424,9 @@ pub mod proxmox_rs_notify { pub fn update_smtp_endpoint( #[try_from_ref] this: &NotificationConfig, name: &str, - server: Option, - port: Option, - mode: Option, - username: Option, - password: Option, - mailto: Option>, - mailto_user: Option>, - from_address: Option, - author: Option, - comment: Option, - disable: Option, + smtp_config_updater: SmtpConfigUpdater, + smtp_private_config_updater: SmtpPrivateConfigUpdater, + oauth2_refresh_token: Option, delete: Option>, digest: Option<&str>, ) -> Result<(), HttpError> { @@ -452,19 +436,9 @@ pub mod proxmox_rs_notify { api::smtp::update_endpoint( &mut config, name, - SmtpConfigUpdater { - server, - port, - mode, - username, - mailto, - mailto_user, - from_address, - author, - comment, - disable, - }, - SmtpPrivateConfigUpdater { password }, + smtp_config_updater, + smtp_private_config_updater, + oauth2_refresh_token, delete.as_deref(), digest.as_deref(), ) -- 2.47.3