From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C06641FF141 for ; Fri, 13 Feb 2026 07:32:30 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6C9D71E11B; Fri, 13 Feb 2026 07:33:14 +0100 (CET) From: Hannes Laimer To: pve-devel@lists.proxmox.com Subject: [PATCH pve-network] sdn: controller: fallback to interface mac if no master Date: Fri, 13 Feb 2026 07:33:05 +0100 Message-ID: <20260213063305.1979-1-h.laimer@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1770964384227 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.060 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 2CYBMQFZSOEFHY6CL55AEV2D6XCH2TM3 X-Message-ID-Hash: 2CYBMQFZSOEFHY6CL55AEV2D6XCH2TM3 X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: For IPv6 underlays, we can't directly use the IP for the router-id. Therefore, `get_router_id` derives a unique ID from the last 4 bytes of the interface MAC. However, the current MAC retrieval logic only checks the master device. This fails for standalone interfaces that do not have a master, such as `dummy_` interfaces used for fabrics. Update `read_iface_mac` to fall back to the interface's own address if no master address is found. Signed-off-by: Hannes Laimer --- src/PVE/Network/SDN/Controllers/Plugin.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/PVE/Network/SDN/Controllers/Plugin.pm b/src/PVE/Network/SDN/Controllers/Plugin.pm index d70e518..cab036a 100644 --- a/src/PVE/Network/SDN/Controllers/Plugin.pm +++ b/src/PVE/Network/SDN/Controllers/Plugin.pm @@ -105,7 +105,9 @@ sub on_update_hook { sub read_iface_mac { my ($iface) = @_; - return PVE::Tools::file_read_firstline("/sys/class/net/$iface/master/address"); + my $mac = PVE::Tools::file_read_firstline("/sys/class/net/$iface/master/address"); + return $mac if $mac; + return PVE::Tools::file_read_firstline("/sys/class/net/$iface/address"); } sub get_router_id { -- 2.47.3