From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 1482E1FF139 for ; Tue, 10 Feb 2026 12:15:32 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BCD091D999; Tue, 10 Feb 2026 12:16:15 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server v2] fix #7119: qm cleanup: wait for process exiting for up to 30 seconds Date: Tue, 10 Feb 2026 12:15:10 +0100 Message-ID: <20260210111612.2017883-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.032 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 6MEANBG5CCTUX6RF4E4YL5FSOMU74RTA X-Message-ID-Hash: 6MEANBG5CCTUX6RF4E4YL5FSOMU74RTA X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: When qmeventd detects a vm exiting, it starts 'qm cleanup' to cleanup files, executing hookscripts, etc. Since the vm process exits is sometimes not instant, wait up to 30 seconds here to start the cleanup process instead of immediately aborting if the pid still exits. This prevented executing the hookscript on the 'post-stop' phase. This can be easily reproduced by e.g. passing through a usb device, which delays the qemu process exit for a few seconds. Signed-off-by: Dominik Csapak --- changes from v1: * use correct while condition (time() is always >= $starttime) original comment: The 30 second timeout was arbitrarily chosen, but we could probably start with something smaller, like 10 seconds? Could be adapted on applying though. In my (short) tests the usb passthrough part only adds a single second, but i can imagine different devices on other systems could block it for much longer. src/PVE/CLI/qm.pm | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/PVE/CLI/qm.pm b/src/PVE/CLI/qm.pm index bdae9641..16875ed2 100755 --- a/src/PVE/CLI/qm.pm +++ b/src/PVE/CLI/qm.pm @@ -1101,8 +1101,19 @@ __PACKAGE__->register_method({ 60, sub { my $conf = PVE::QemuConfig->load_config($vmid); + + # wait for some timeout until vm process exits, since this might not be instant + my $timeout = 30; + my $starttime = time(); my $pid = PVE::QemuServer::check_running($vmid); - die "vm still running\n" if $pid; + warn "vm still running - waiting up to $timeout seconds\n" if $pid; + + while ($pid && (time() - $starttime) < $timeout) { + sleep(1); + $pid = PVE::QemuServer::check_running($vmid); + } + + die "vm still running - aborting cleanup\n" if $pid; # Rollback already does cleanup when preparing and afterwards temporarily drops the # lock on the configuration file to rollback the volumes. Deactivating volumes here -- 2.47.3