From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 6DC7D1FF136 for ; Mon, 09 Feb 2026 16:49:10 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 87665C480; Mon, 9 Feb 2026 16:49:52 +0100 (CET) From: Lukas Sichert To: pve-devel@lists.proxmox.com Subject: [PATCH container] networkedit: fix #4911: changed primaryfield to proxmoxtextfield to allow empty bond-primary Date: Mon, 9 Feb 2026 16:49:16 +0100 Message-ID: <20260209154916.54446-1-l.sichert@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: RQEEB4B6UHUWZLXN3SBPTUTOSFTGMEV7 X-Message-ID-Hash: RQEEB4B6UHUWZLXN3SBPTUTOSFTGMEV7 X-MailFrom: lsichert@pve.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Lukas Sichert X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Currently, when creating an active-backup bond, it is not possible to leave the primary-bond field blank, even though this value is optional in the backend. If no value is currently set in the frontend, it sends the value '' to the backend. There, it is interpreted as the name of an interface, which is incorrect, and therefore the error 'bond-primary: invalid format - invalid network interface name '' ' is displayed. Changing the field type to 'proxmoxtextfield' will prevent the empty string from being sent due to the way we submit the data and make it therefore possible to not set any value in the frontend. Addtionally, the deleteEmpty flag is set, so that devices, that were unset, will be deleted by the backend. Signed-off-by: Lukas Sichert --- src/node/NetworkEdit.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/node/NetworkEdit.js b/src/node/NetworkEdit.js index 39c7e35..c945139 100644 --- a/src/node/NetworkEdit.js +++ b/src/node/NetworkEdit.js @@ -239,10 +239,11 @@ Ext.define('Proxmox.node.NetworkEdit', { disabled: true, }); - let primaryfield = Ext.createWidget('textfield', { + let primaryfield = Ext.createWidget('proxmoxtextfield', { fieldLabel: 'bond-primary', name: 'bond-primary', value: '', + deleteEmpty: !me.isCreate, disabled: true, }); -- 2.47.3