From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 43F7F1FF137 for ; Tue, 03 Feb 2026 15:12:06 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B2EE12009A; Tue, 3 Feb 2026 15:12:36 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server] machine: fix not trying to set S3/S4 ACPI power state for virt machine Date: Tue, 3 Feb 2026 15:10:50 +0100 Message-ID: <20260203141202.3567520-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.032 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: USESGIPCS5CZJUYJBTDXQPVW5WDGV6M7 X-Message-ID-Hash: USESGIPCS5CZJUYJBTDXQPVW5WDGV6M7 X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: For aarch64 the default machine is 'virt' already, so we have to consider this case as well here. Signed-off-by: Dominik Csapak --- we could maybe also just skip this entire function if the arch is not 'x86_64'. Can send a v2 with that if that's preferred. src/PVE/QemuServer.pm | 2 +- src/PVE/QemuServer/Machine.pm | 7 +++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index dae72c40..5d2dbe03 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -3730,7 +3730,7 @@ sub config_to_command { push @$machineFlags, 'accel=tcg'; } my $power_state_flags = - PVE::QemuServer::Machine::get_power_state_flags($machine_conf, $version_guard); + PVE::QemuServer::Machine::get_power_state_flags($machine_conf, $arch, $version_guard); push $cmd->@*, $power_state_flags->@* if defined($power_state_flags); push @$machineFlags, 'smm=off' if should_disable_smm($conf, $vga, $machine_type); diff --git a/src/PVE/QemuServer/Machine.pm b/src/PVE/QemuServer/Machine.pm index 93a90c47..c5f0104a 100644 --- a/src/PVE/QemuServer/Machine.pm +++ b/src/PVE/QemuServer/Machine.pm @@ -468,9 +468,12 @@ sub check_and_pin_machine_string { # disable s3/s4 by default for 9.2+pve1 machine types # returns an arrayref of cmdline options for qemu or undef sub get_power_state_flags { - my ($machine_conf, $version_guard) = @_; + my ($machine_conf, $arch, $version_guard) = @_; - if (defined($machine_conf->{type}) && $machine_conf->{type} =~ /^virt/) { + if ( + defined($machine_conf->{type}) && $machine_conf->{type} =~ /^virt/ + || !defined($machine_conf->{type}) && $arch eq 'aarch64' + ) { return; # virt machines are normally ARM64 ones which have no concept of s3/s4 } -- 2.47.3