From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 630181FF137 for ; Tue, 03 Feb 2026 11:22:00 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EEB5C1943D; Tue, 3 Feb 2026 11:21:59 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Subject: [PATCH manager v2 07/17] ui: qemu: make scsi hw selector architecture aware Date: Tue, 3 Feb 2026 11:00:12 +0100 Message-ID: <20260203102118.1430545-8-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260203102118.1430545-1-d.csapak@proxmox.com> References: <20260203102118.1430545-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.032 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: JAUGHFV5YQZQJPFZ3AKKJIETK4KYXHAW X-Message-ID-Hash: JAUGHFV5YQZQJPFZ3AKKJIETK4KYXHAW X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: e.g. on aarch64 it makes only sense to use virtio-scsi or virtio-scsi-single, so hide all other values, by adding a filter on the internal store that allows only certain values. Default to 'x86_64' for the architecture. By using a setter for 'nodename' and 'arch' this also works in a context where we can bind the values to these fields, e.g. in the wizard. To properly trigger validation, we have to check the state before and after setting the filter, since just a filter change, does not trigger a validity change in the form field it seems. Signed-off-by: Dominik Csapak --- www/manager6/form/ScsiHwSelector.js | 6 +++++- www/manager6/qemu/ScsiHwEdit.js | 1 + www/manager6/qemu/SystemEdit.js | 1 + 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/www/manager6/form/ScsiHwSelector.js b/www/manager6/form/ScsiHwSelector.js index d35a5b3a..af751b80 100644 --- a/www/manager6/form/ScsiHwSelector.js +++ b/www/manager6/form/ScsiHwSelector.js @@ -1,5 +1,5 @@ Ext.define('PVE.form.ScsiHwSelector', { - extend: 'Proxmox.form.KVComboBox', + extend: 'PVE.form.FilteredKVComboBox', alias: ['widget.pveScsiHwSelector'], comboItems: [ ['__default__', PVE.Utils.render_scsihw('')], @@ -10,4 +10,8 @@ Ext.define('PVE.form.ScsiHwSelector', { ['virtio-scsi-single', PVE.Utils.render_scsihw('virtio-scsi-single')], ['pvscsi', PVE.Utils.render_scsihw('pvscsi')], ], + + allowedValuesPerCategory: PVE.qemu.Architecture.allowedScsiHw, + + setDefaultDisplay: (arch) => PVE.Utils.render_scsihw('', arch), }); diff --git a/www/manager6/qemu/ScsiHwEdit.js b/www/manager6/qemu/ScsiHwEdit.js index 48dcb228..a3264212 100644 --- a/www/manager6/qemu/ScsiHwEdit.js +++ b/www/manager6/qemu/ScsiHwEdit.js @@ -11,6 +11,7 @@ Ext.define('PVE.qemu.ScsiHwEdit', { name: 'scsihw', value: '__default__', fieldLabel: gettext('Type'), + category: me.arch, }, }); diff --git a/www/manager6/qemu/SystemEdit.js b/www/manager6/qemu/SystemEdit.js index 2cf17e8e..bec9fef1 100644 --- a/www/manager6/qemu/SystemEdit.js +++ b/www/manager6/qemu/SystemEdit.js @@ -139,6 +139,7 @@ Ext.define('PVE.qemu.SystemInputPanel', { name: 'scsihw', value: '__default__', bind: { + category: '{current.architecture}', value: '{current.scsihw}', }, fieldLabel: gettext('SCSI Controller'), -- 2.47.3