From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 90E101FF137 for ; Tue, 03 Feb 2026 11:22:35 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5CCDB19BD8; Tue, 3 Feb 2026 11:22:23 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Subject: [PATCH manager v2 13/17] ui: qemu: wizard: use defaults to populate machine and bios Date: Tue, 3 Feb 2026 11:00:18 +0100 Message-ID: <20260203102118.1430545-14-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260203102118.1430545-1-d.csapak@proxmox.com> References: <20260203102118.1430545-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.032 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 5NE77IFTOXKZXNIPPGLFM2QTHOKNMLZF X-Message-ID-Hash: 5NE77IFTOXKZXNIPPGLFM2QTHOKNMLZF X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: instead of hardcoding some values here for win11, use the OSDefaults mechanism to load it for all. This makes it also architecture aware. rename the function to 'setDefaults' as it's a more fitting name now. Signed-off-by: Dominik Csapak --- www/manager6/qemu/OSDefaults.js | 7 +++++++ www/manager6/qemu/SystemEdit.js | 13 +++++++++---- 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/www/manager6/qemu/OSDefaults.js b/www/manager6/qemu/OSDefaults.js index d921ab53..a2c218df 100644 --- a/www/manager6/qemu/OSDefaults.js +++ b/www/manager6/qemu/OSDefaults.js @@ -111,6 +111,13 @@ Ext.define('PVE.qemu.OSDefaults', { parent: 'w2k', }); + addOS({ + pveOS: 'win11', + parent: 'generic', + machine: 'q35', + bios: 'ovmf', + }); + me.getDefaults = function (ostype, arch = 'x86_64') { if (!PVE.qemu.OSDefaults[ostype]) { ostype = 'generic'; diff --git a/www/manager6/qemu/SystemEdit.js b/www/manager6/qemu/SystemEdit.js index 0c1e03ca..299be5f8 100644 --- a/www/manager6/qemu/SystemEdit.js +++ b/www/manager6/qemu/SystemEdit.js @@ -57,19 +57,24 @@ Ext.define('PVE.qemu.SystemInputPanel', { change: 'biosChange', }, '#': { - afterrender: 'setMachine', + afterrender: 'setDefaults', }, }, - setMachine: function () { + setDefaults: function () { let me = this; let vm = this.getViewModel(); + let ostype = vm.get('current.ostype'); + let architecture = vm.get('current.architecture'); + + let defaults = PVE.qemu.OSDefaults.getDefaults(ostype, architecture); if (ostype === 'win11') { - me.lookup('machine').setValue('q35'); - me.lookup('bios').setValue('ovmf'); me.lookup('addtpmbox').setValue(true); } + + me.lookup('machine').setValue(defaults.machine ?? '__default__'); + me.lookup('bios').setValue(defaults.bios ?? '__default__'); }, }, -- 2.47.3