From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 41D191FF13F for ; Thu, 29 Jan 2026 14:10:35 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0086B30A8; Thu, 29 Jan 2026 14:10:33 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server v2 4/8] cpu config: introduce module-wide $host_arch variable Date: Thu, 29 Jan 2026 14:10:01 +0100 Message-ID: <20260129131021.118199-5-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260129131021.118199-1-f.ebner@proxmox.com> References: <20260129131021.118199-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1769692157232 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.017 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: KE5NXTVDAMVWECLHE7NHIL4YQA3ROYNJ X-Message-ID-Hash: KE5NXTVDAMVWECLHE7NHIL4YQA3ROYNJ X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: It cannot change while the module is loaded. Also, commit "cpu config: support aarch64 CPU models" will use the host arch as a hash key, which is cleaner if no additional function call is required. Signed-off-by: Fiona Ebner --- src/PVE/QemuServer/CPUConfig.pm | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/PVE/QemuServer/CPUConfig.pm b/src/PVE/QemuServer/CPUConfig.pm index 825e691a..2825da46 100644 --- a/src/PVE/QemuServer/CPUConfig.pm +++ b/src/PVE/QemuServer/CPUConfig.pm @@ -9,7 +9,7 @@ use PVE::JSONSchema qw(json_bool); use PVE::Cluster qw(cfs_register_file cfs_read_file); use PVE::ProcFSTools; use PVE::RESTEnvironment qw(log_warn); -use PVE::Tools qw(run_command get_host_arch); +use PVE::Tools qw(run_command); use PVE::QemuServer::Helpers qw(min_version); @@ -25,6 +25,8 @@ our @EXPORT_OK = qw( get_cvm_type ); +my $host_arch = PVE::Tools::get_host_arch(); + my $arch_desc = { description => "Virtual processor architecture. Defaults to the host architecture.", type => 'string', @@ -1016,13 +1018,13 @@ sub get_default_cpu_type { sub is_native_arch($) { my ($arch) = @_; - return get_host_arch() eq $arch; + return $host_arch eq $arch; } sub get_cpu_bitness { my ($cpu_prop_str, $arch) = @_; - $arch //= get_host_arch(); + $arch //= $host_arch; my $cputype = get_default_cpu_type($arch, 0); -- 2.47.3