From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 292361FF145 for ; Thu, 22 Jan 2026 14:51:48 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D7A1A1780B; Thu, 22 Jan 2026 14:52:04 +0100 (CET) From: Hannes Laimer To: pve-devel@lists.proxmox.com Date: Thu, 22 Jan 2026 14:51:49 +0100 Message-ID: <20260122135151.292794-5-h.laimer@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260122135151.292794-1-h.laimer@proxmox.com> References: <20260122135151.292794-1-h.laimer@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1769089864042 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.939 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_MAILER 2 Automated Mailer Tag Left in Email SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH pve-network 4/6] sdn: evpn: keep router-id valid on IPv6 underlay X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" BGP router-ids are 32-bit values, so use get_router_id() instead of the address directly, cause that would only work for IPv4 underlays. And remove dead code in the EVPN zone plugin, we don't need the router-id there anywhere. Signed-off-by: Hannes Laimer --- src/PVE/Network/SDN/Controllers/EvpnPlugin.pm | 4 ++-- src/PVE/Network/SDN/Zones/EvpnPlugin.pm | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/PVE/Network/SDN/Controllers/EvpnPlugin.pm b/src/PVE/Network/SDN/Controllers/EvpnPlugin.pm index 88bdcb8..8bc00c7 100644 --- a/src/PVE/Network/SDN/Controllers/EvpnPlugin.pm +++ b/src/PVE/Network/SDN/Controllers/EvpnPlugin.pm @@ -116,7 +116,7 @@ sub generate_frr_config { $loopback = "dummy_$fabric->{id}"; $ifaceip = $current_node->{$addr_key}; - $routerid = $current_node->{$addr_key}; + $routerid = PVE::Network::SDN::Controllers::Plugin::get_router_id($ifaceip, $loopback); } elsif ($plugin_config->{'peers'}) { @peers = PVE::Tools::split_list($plugin_config->{'peers'}); @@ -268,7 +268,7 @@ sub generate_zone_frr_config { $loopback = "dummy_$fabric->{id}"; $ifaceip = $current_node->{$addr_key}; - $routerid = $current_node->{$addr_key}; + $routerid = PVE::Network::SDN::Controllers::Plugin::get_router_id($ifaceip, $loopback); } elsif ($controller->{peers}) { @peers = PVE::Tools::split_list($controller->{'peers'}) if $controller->{'peers'}; diff --git a/src/PVE/Network/SDN/Zones/EvpnPlugin.pm b/src/PVE/Network/SDN/Zones/EvpnPlugin.pm index 227d917..9aeced5 100644 --- a/src/PVE/Network/SDN/Zones/EvpnPlugin.pm +++ b/src/PVE/Network/SDN/Zones/EvpnPlugin.pm @@ -145,7 +145,6 @@ sub generate_sdn_config { my $loopback = undef; my $ifaceip = undef; my $iface = undef; - my $routerid = undef; if ($controller->{peers}) { @peers = PVE::Tools::split_list($controller->{'peers'}); @@ -204,7 +203,6 @@ sub generate_sdn_config { $loopback = "dummy_$fabric->{id}"; $ifaceip = $current_node->{$addr_key}; - $routerid = $current_node->{$addr_key}; } else { die "neither fabric nor peers configured for EVPN controller $controller->{id}"; } -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel