From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id DE0811FF145 for ; Thu, 22 Jan 2026 14:52:19 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4052917A1C; Thu, 22 Jan 2026 14:52:30 +0100 (CET) From: Hannes Laimer To: pve-devel@lists.proxmox.com Date: Thu, 22 Jan 2026 14:51:47 +0100 Message-ID: <20260122135151.292794-3-h.laimer@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260122135151.292794-1-h.laimer@proxmox.com> References: <20260122135151.292794-1-h.laimer@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1769089859861 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.441 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLACK 3 Contains an URL listed in the URIBL blacklist [plugin.pm] Subject: [pve-devel] [PATCH pve-network 2/6] sdn: controller: fallback to interface mac if no master X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" For IPv6 underlays, we can't directly use the IP for the router-id. Therefore, `get_router_id` derives a unique ID from the last 4 bytes of the interface MAC. However, the current MAC retrieval logic only checks the master device. This fails for standalone interfaces that do not have a master, such as `dummy_` interfaces used for fabrics. Update `read_iface_mac` to fall back to the interface's own address if no master address is found. Signed-off-by: Hannes Laimer --- src/PVE/Network/SDN/Controllers/Plugin.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/PVE/Network/SDN/Controllers/Plugin.pm b/src/PVE/Network/SDN/Controllers/Plugin.pm index d70e518..cab036a 100644 --- a/src/PVE/Network/SDN/Controllers/Plugin.pm +++ b/src/PVE/Network/SDN/Controllers/Plugin.pm @@ -105,7 +105,9 @@ sub on_update_hook { sub read_iface_mac { my ($iface) = @_; - return PVE::Tools::file_read_firstline("/sys/class/net/$iface/master/address"); + my $mac = PVE::Tools::file_read_firstline("/sys/class/net/$iface/master/address"); + return $mac if $mac; + return PVE::Tools::file_read_firstline("/sys/class/net/$iface/address"); } sub get_router_id { -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel