From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 31F731FF145 for ; Thu, 22 Jan 2026 11:55:35 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0D9CB137C6; Thu, 22 Jan 2026 11:55:53 +0100 (CET) From: Arthur Bied-Charreton To: pve-devel@lists.proxmox.com Date: Thu, 22 Jan 2026 11:55:16 +0100 Message-ID: <20260122105516.135778-1-a.bied-charreton@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.010 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH pve-cluster] fix #6701: Add keyUsage extension to root CA X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Add the keyUsage[1] extension to the PVE root CA to comply with RFC 5280. Python started to enforce this as of 3.13 by defaulting to using the VERIFY_X509_STRICT flag, which breaks clients like Ansible. The authorityKeyIdentifier[2] and subjectKeyIdentifier[3] extensions are not strictly required for fixing this issue, however RFC 5280 mandates them for conforming CAs, so adding them makes sense as well. [1] https://www.rfc-editor.org/rfc/rfc5280#section-4.2.1.3 [2] https://www.rfc-editor.org/rfc/rfc5280#section-4.2.1.1 [3] https://www.rfc-editor.org/rfc/rfc5280#section-4.2.1.2 Signed-off-by: Arthur Bied-Charreton --- This fix is not required for PBS and PDM, since they only use self-signed certificates. You can run the script below to test the changes, should fail with "CA cert does not include key usage extension" before applying the patch, and succeed afterwards. ``` #!/usr/bin/env python3 import socket import ssl import sys try: context = ssl.create_default_context(cafile="/etc/pve/pve-root-ca.pem") context.check_hostname = True context.verify_mode = ssl.CERT_REQUIRED with socket.create_connection(("localhost", 8006), timeout=10) as sock: with context.wrap_socket(sock, server_hostname="localhost") as ssock: print(f"success") except ssl.SSLCertVerificationError as e: print(e) ``` src/PVE/Cluster/Setup.pm | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/src/PVE/Cluster/Setup.pm b/src/PVE/Cluster/Setup.pm index 75d3507..d95a278 100644 --- a/src/PVE/Cluster/Setup.pm +++ b/src/PVE/Cluster/Setup.pm @@ -426,6 +426,25 @@ sub gen_pveca_cert { my $uuid_str; UUID::unparse($uuid, $uuid_str); + my $sslconf = <<__EOD; +[req] +distinguished_name = req_distinguished_name +x509_extensions = v3_ca + +[ req_distinguished_name ] + +[ v3_ca ] +basicConstraints = critical,CA:TRUE +keyUsage = critical,keyCertSign,cRLSign +authorityKeyIdentifier = keyid:always,issuer +subjectKeyIdentifier = hash +__EOD + + my $cfgfn = "/tmp/pvesslconf-$$.tmp"; + my $fh = IO::File->new($cfgfn, "w"); + print $fh $sslconf; + close($fh); + eval { # wrap openssl with faketime to prevent bug #904 run_silent_cmd([ @@ -439,6 +458,8 @@ sub gen_pveca_cert { '-new', '-x509', '-nodes', + '-config', + $cfgfn, '-key', $pveca_key_fn, '-out', @@ -448,6 +469,8 @@ sub gen_pveca_cert { ]); }; + unlink $cfgfn; + die "generating pve root certificate failed:\n$@" if $@; return 1; -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel