From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 304F31FF146 for ; Tue, 20 Jan 2026 16:28:45 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 834111329A; Tue, 20 Jan 2026 16:28:35 +0100 (CET) From: Daniel Kral To: pve-devel@lists.proxmox.com Date: Tue, 20 Jan 2026 16:27:42 +0100 Message-ID: <20260120152755.499037-11-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260120152755.499037-1-d.kral@proxmox.com> References: <20260120152755.499037-1-d.kral@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1768922824976 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH ha-manager v2 10/12] config: factor out checked_resources_config helper X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" This allows future users to retrieve the checked resource config if these already have a parsed resource config instead of reading it twice. Signed-off-by: Daniel Kral --- changes v1 -> v2: - new! src/PVE/HA/Config.pm | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/PVE/HA/Config.pm b/src/PVE/HA/Config.pm index d01b43d8..7607b194 100644 --- a/src/PVE/HA/Config.pm +++ b/src/PVE/HA/Config.pm @@ -105,10 +105,9 @@ sub read_resources_config { return cfs_read_file($ha_resources_config); } -# checks if resource exists and sets defaults for unset values -sub read_and_check_resources_config { - - my $cfg = cfs_read_file($ha_resources_config); +# returns resources config with defaults and node placement set +my sub checked_resources_config { + my ($cfg) = @_; my $vmlist = PVE::Cluster::get_vmlist(); my $resources = {}; @@ -137,6 +136,13 @@ sub read_and_check_resources_config { return wantarray ? ($resources, $cfg->{digest}) : $resources; } +# checks if resource exists and sets defaults for unset values +sub read_and_check_resources_config { + my $cfg = cfs_read_file($ha_resources_config); + + return checked_resources_config($cfg); +} + my sub update_single_resource_config_inplace { my ($cfg, $sid, $param, $delete) = @_; -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel