From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E2FA91FF15E for ; Tue, 20 Jan 2026 09:49:04 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2DF3985DB; Tue, 20 Jan 2026 09:49:15 +0100 (CET) From: Daniel Kral To: pve-devel@lists.proxmox.com Date: Tue, 20 Jan 2026 09:47:53 +0100 Message-ID: <20260120084839.103702-2-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260120084839.103702-1-d.kral@proxmox.com> References: <20260120084839.103702-1-d.kral@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1768898867709 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [manager.pm] Subject: [pve-devel] [PATCH ha-manager v2 1/4] fix #7133: manager: group migration: skip update for resources without group X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" The HA group migration is executed if the HA groups config is still present in the HA config directory and individually updates every HA resource, even if none of those are part of a HA group. The call to update_service_config(...) for the HA resources without group assignments cause unnecessary updates to the config and can become costly with higher HA resource counts, which might prevent the CRM to update its watchdog in time, so skip these updates. Signed-off-by: Daniel Kral Reviewed-by: Fiona Ebner --- src/PVE/HA/Manager.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Manager.pm index f5843dd4..80b29966 100644 --- a/src/PVE/HA/Manager.pm +++ b/src/PVE/HA/Manager.pm @@ -580,6 +580,9 @@ my $migrate_group_persistently = sub { PVE::HA::Groups::migrate_groups_to_resources($groups, $resources); for my $sid (keys %$resources) { + # prevent unnecessary updates for HA resources that do not change + next if !defined($resources->{$sid}->{group}); + my $param = { failback => $resources->{$sid}->{failback} }; $haenv->update_service_config($sid, $param, 'group'); -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel