From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 09BEE1FF17A for ; Tue, 20 Jan 2026 09:48:45 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BA84A847A; Tue, 20 Jan 2026 09:48:45 +0100 (CET) From: Daniel Kral To: pve-devel@lists.proxmox.com Date: Tue, 20 Jan 2026 09:47:52 +0100 Message-ID: <20260120084839.103702-1-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1768898867605 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [hardware.pm, resources.pm, config.pm, manager.pm, pve2.pm, env.pm] Subject: [pve-devel] [PATCH-SERIES ha-manager v2 0/4] fix #7133 and improve HA group migration X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Changes from v1 to v2 (Thanks @Fiona!): - pull $delete parameter into $changes hash in update_{service,resources}_config - sort the HA resources' sids when iterating over the $changes hash Tested the changes for v2 again with: - creating a groups.cfg and checking whether the groups have been correctly migrated, - changing a HA resource to stopped state changes the config too, & - changing a HA resource's config through the API reflects the changes in the resources.cfg. This small patch series improves the HA groups to rules migration for HA setups with a lot of HA resources: - Patch 1 reduces the amount of unnecessary updates and is enough for fixing #7133, - Patch 2 removes redundant failback flag writes to reduce the resource config file size, and patch, and - Patch 3-4 make the resource config in a single write instead of individual writes. Tested this for a PVE 8.4 to PVE 9.1 3-node cluster upgrade. Daniel Kral (4): fix #7133: manager: group migration: skip update for resources without group manager: group migration: write only non-default failback values config, env: allow bulk updates with update_service_config manager: group migration: bulk update changes to resource config src/PVE/API2/HA/Resources.pm | 8 ++++- src/PVE/HA/Config.pm | 57 +++++++++++++++++++++--------------- src/PVE/HA/Env.pm | 4 +-- src/PVE/HA/Env/PVE2.pm | 4 +-- src/PVE/HA/Manager.pm | 15 ++++++++-- src/PVE/HA/Sim/Env.pm | 4 +-- src/PVE/HA/Sim/Hardware.pm | 19 +++++++++--- 7 files changed, 74 insertions(+), 37 deletions(-) -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel