From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 397441FF187 for ; Fri, 19 Dec 2025 20:45:21 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3BF0114732; Fri, 19 Dec 2025 20:45:44 +0100 (CET) From: "Max R. Carrara" To: pve-devel@lists.proxmox.com Date: Fri, 19 Dec 2025 20:44:49 +0100 Message-ID: <20251219194511.840583-15-m.carrara@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251219194511.840583-1-m.carrara@proxmox.com> References: <20251219194511.840583-1-m.carrara@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1766173527649 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.084 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH pve-common v1 14/23] tests: sectionconfig: add case for same prop. w/ different optionality X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Add a PVE::SectionConfig isolated mode test case where a property with the same name, but differing optionality is defined on two plugins. That is, the name is the same, but one has `optional => 1`, whereas the other has `optional => 0`. In both create and update schema, both properties are marked as optional, because properties added by child plugins are always marked as optional. Signed-off-by: Max R. Carrara --- test/SectionConfig/schema_isolated_test.pl | 133 +++++++++++++++++++++ 1 file changed, 133 insertions(+) diff --git a/test/SectionConfig/schema_isolated_test.pl b/test/SectionConfig/schema_isolated_test.pl index 4b14d8a..a94dcb1 100755 --- a/test/SectionConfig/schema_isolated_test.pl +++ b/test/SectionConfig/schema_isolated_test.pl @@ -303,6 +303,139 @@ package IdenticalPropertyOnDifferentPlugin { } } +package SamePropertyNamesOnDifferentPlugins { + use base qw(TestPackage); + + sub desc($class) { + return + "defining properties with the same name but different optionality" + . " on different plugins does not lead to 'oneOf' being used inside" + . " either createSchema or updateSchema - because properties defined" + . " by plugins are always marked as optional"; + } + + package SamePropertyNamesOnDifferentPlugins::PluginBase { + use base qw(PVE::SectionConfig); + + my $DEFAULT_DATA = {}; + + sub private($class) { + return $DEFAULT_DATA; + } + }; + + package SamePropertyNamesOnDifferentPlugins::PluginOne { + use base qw(SamePropertyNamesOnDifferentPlugins::PluginBase); + + sub type($class) { + return 'one'; + } + + sub properties($class) { + return { + 'prop-one' => { + type => 'string', + optional => 0, + }, + 'prop-two' => { + type => 'string', + optional => 1, + }, + }; + } + + sub options($class) { + return { + 'prop-one' => { + optional => 0, + }, + 'prop-two' => { + optional => 1, + }, + }; + } + }; + + package SamePropertyNamesOnDifferentPlugins::PluginTwo { + use base qw(SamePropertyNamesOnDifferentPlugins::PluginBase); + + sub type($class) { + return 'two'; + } + + sub properties($class) { + return { + 'prop-one' => { + type => 'string', + optional => 1, + }, + 'prop-two' => { + type => 'string', + optional => 0, + }, + }; + } + + sub options($class) { + return { + 'prop-one' => { + optional => 1, + }, + 'prop-two' => { + optional => 0, + }, + }; + } + }; + + sub expected_isolated_createSchema($class) { + return { + type => 'object', + additionalProperties => 0, + properties => { + type => { + type => 'string', + enum => [ + "one", "two", + ], + }, + 'prop-one' => { + type => 'string', + optional => 1, + }, + 'prop-two' => { + type => 'string', + optional => 1, + }, + }, + }; + } + + sub expected_isolated_updateSchema($class) { + return { + type => 'object', + additionalProperties => 0, + properties => { + type => { + type => 'string', + enum => [ + "one", "two", + ], + }, + 'prop-one' => { + type => 'string', + optional => 1, + }, + 'prop-two' => { + type => 'string', + optional => 1, + }, + $SectionConfig::Helpers::UPDATE_SCHEMA_DEFAULT_PROPERTIES->%*, + }, + }; + } +} + sub test_compare_deeply($got, $expected, $test_name, $test_package) { $test_name = "$test_package - $test_name"; my $description = $test_package->desc(); -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel