From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 6F2701FF187 for ; Fri, 19 Dec 2025 20:45:27 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4C61E146D5; Fri, 19 Dec 2025 20:45:45 +0100 (CET) From: "Max R. Carrara" To: pve-devel@lists.proxmox.com Date: Fri, 19 Dec 2025 20:44:35 +0100 Message-ID: <20251219194511.840583-1-m.carrara@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1766173498209 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.084 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH pve-common v1 00/23] Document PVE::SectionConfig Peculiarities X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Document PVE::SectionConfig Peculiarities - v1 ============================================== This was a long overdue series that adds a bunch of unit tests and documentation updates for PVE::SectionConfig. The main motivation for this series is me running somewhat regularly into new discoveries when using PVE::SectionConfig for other purposes or investigating how certain schemas are generated. Since there have been quite a few surprises and somewhat sharp corners, I decided to document all of these "peculiarities" in the form of unit / regression tests instead of lengthy, wordy, borderline incomprehensible paragraphs in the PVE::SectionConfig POD. (Seriously, some behaviors are quite hard to parse when written out as text.) The additional benefit of these tests is that they (should) guard us against any regressions, should we have to make changes to the PVE::SectionConfig machinery at some point in the future. On top of that, we could use them as reference for aligning the Perl and Rust SectionConfig / JSONSchema implementations in the future. The commits should hopefully explain everything in detail. Note though that these tests are by no means exhaustive. The test scripts are however designed in such a way that it should be relatively simple to add new cases whenever a new quirk pops up. Finally, the POD docstrings in the PVE::SectionConfig source are also adapted / corrected / clarified etc., which was made possible by the insights gained from writing all of these tests. References ========== [0]: https://lore.proxmox.com/pve-devel/20251121165858.818307-1-m.carrara@proxmox.com/ Summary of Changes ================== Max R. Carrara (23): sectionconfig: remove unused variable in get_property_schema() tests: sectionconfig: add comparison test structure tests: sectionconfig: add test case for fixed props in updateSchema tests: sectionconfig: add case for unused properties tests: sectionconfig: add case for unused optional default properties tests: sectionconfig: add case for opt. default prop being req. once tests: sectionconfig: add case for opt. default prop requirde by all tests: sectionconfig: add case for unused required default properties tests: sectionconfig: add case for req. default prop being req. once tests: sectionconfig: add case for required default prop req. by all tests: sectionconfig: add case for required default props opt. for all tests: sectionconfig: add isolated mode test structure tests: sectionconfig: add case for an ident. prop on two plugins tests: sectionconfig: add case for same prop. w/ different optionality tests: sectionconfig: add case for differing opt. default prop uses tests: sectionconfig: add case for differing req. default prop uses sectionconfig: correct docs regarding global props in unified mode sectionconfig: reword docs regarding property usage in isolated mode sectionconfig: extend / correct docstring of `private()` method sectionconfig: note that a prop must be defined through a JSONSchema sectionconfig: note that props added by plugins are always optional sectionconfig: note that `createSchema()` is universal for all plugins sectionconfig: correct example in docstring of `updateSchema()` src/PVE/SectionConfig.pm | 62 +- test/Makefile | 5 +- test/SectionConfig/Helpers.pm | 114 + test/SectionConfig/Makefile | 11 + test/SectionConfig/schema_comparison_test.pl | 2047 ++++++++++++++++++ test/SectionConfig/schema_isolated_test.pl | 826 +++++++ 6 files changed, 3047 insertions(+), 18 deletions(-) create mode 100644 test/SectionConfig/Helpers.pm create mode 100644 test/SectionConfig/Makefile create mode 100755 test/SectionConfig/schema_comparison_test.pl create mode 100755 test/SectionConfig/schema_isolated_test.pl -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel