From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B20C21FF187 for ; Fri, 19 Dec 2025 15:46:32 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7C7D2ED48; Fri, 19 Dec 2025 15:47:20 +0100 (CET) From: Dominik Rusovac To: pve-devel@lists.proxmox.com Date: Fri, 19 Dec 2025 15:46:35 +0100 Message-ID: <20251219144635.168818-1-d.rusovac@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1766155593509 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.000 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH proxmox-widget-toolkit] fix #7087: ui: enable direct task log download X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Dominik Rusovac Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" The web ui of both, PVE and PBS, now includes a "Download" button allowing for a task log to be downloaded directly without opening the task viewer pop-up. The enhancement originally related to PBS only, however this change applies to PVE too and it seems more convenient to have it for both. Signed-off-by: Dominik Rusovac --- Notes: If desired, I could take on the implementation of download buttons for PDM. src/node/Tasks.js | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/src/node/Tasks.js b/src/node/Tasks.js index 661329a..002d909 100644 --- a/src/node/Tasks.js +++ b/src/node/Tasks.js @@ -35,6 +35,21 @@ Ext.define('Proxmox.node.Tasks', { }).show(); }, + downloadTaskLog: function () { + let me = this; + let selection = me.getView().getSelection(); + if (selection.length < 1) { + return; + } + + let rec = selection[0]; + let task = Proxmox.Utils.parse_task_upid(rec.data.upid); + + Proxmox.Utils.downloadAsFile( + `/api2/json/nodes/${task.node}/tasks/${encodeURIComponent(rec.data.upid)}/log?download=1`, + ); + }, + updateLayout: function (store, records, success, operation) { let me = this; let view = me.getView().getView(); // the table view, not the whole grid @@ -236,6 +251,13 @@ Ext.define('Proxmox.node.Tasks', { disabled: true, handler: 'showTaskLog', }, + { + xtype: 'proxmoxButton', + text: gettext('Download'), + iconCls: 'fa fa-download', + disabled: true, + handler: 'downloadTaskLog', + }, { xtype: 'button', text: gettext('Reload'), -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel