From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 421C01FF187 for ; Fri, 19 Dec 2025 11:54:26 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4E43E94C3; Fri, 19 Dec 2025 11:55:15 +0100 (CET) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Fri, 19 Dec 2025 11:54:27 +0100 Message-ID: <20251219105431.155671-2-c.heiss@proxmox.com> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251219105431.155671-1-c.heiss@proxmox.com> References: <20251219105431.155671-1-c.heiss@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1766141669510 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.052 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server 1/3] config: fix OVMF typo in error message X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Signed-off-by: Christoph Heiss --- As we translate that string in the UI (see also next patch), this can lead to this error being untranslated in the UI in certain package version combinations (i.e. newer qemu-server, older pve-manager). Not sure if we consider something like that breaking though, at has least no functional impact per se. src/PVE/QemuConfig.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/QemuConfig.pm b/src/PVE/QemuConfig.pm index ad6ce6b0..844ed69a 100644 --- a/src/PVE/QemuConfig.pm +++ b/src/PVE/QemuConfig.pm @@ -194,7 +194,7 @@ sub get_backup_volumes { if ($key =~ m/^efidisk/ && (!defined($conf->{bios}) || $conf->{bios} ne 'ovmf')) { $included = 0; - $reason = "efidisk but no OMVF BIOS"; + $reason = "efidisk but no OVMF BIOS"; } push @$return_volumes, -- 2.51.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel