From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 0C8E51FF17C for ; Tue, 16 Dec 2025 14:02:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 57392EE92; Tue, 16 Dec 2025 14:02:39 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Tue, 16 Dec 2025 14:02:19 +0100 Message-ID: <20251216130230.104772-9-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251216130230.104772-1-f.ebner@proxmox.com> References: <20251216130230.104772-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1765890145920 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_MAILER 2 Automated Mailer Tag Left in Email SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH storage 08/11] plugin: volume snapshot info: don't set 'order' for internal snapshots X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" The 'order' property is only used for external snapshots. For internal qcow2 snapshots, when a new snapshot is taken, the ID is one more than the highest currently present ID. Thus, the order is currently reversed compared to the one for the external snapshot backing chain, where images further back in the chain have higher IDs. Just drop the information, since it is not used. The qcow2 ID cannot be used for the 'id' property for replication either, because two snapshots with the same name might end up with the same ID, which violates a requirement. Signed-off-by: Fiona Ebner --- src/PVE/Storage/Plugin.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm index 221c872..1fc2b8f 100644 --- a/src/PVE/Storage/Plugin.pm +++ b/src/PVE/Storage/Plugin.pm @@ -1916,7 +1916,6 @@ sub volume_snapshot_info { my $snapshots = $json_decode->{snapshots}; for my $snap (@$snapshots) { my $snapname = $snap->{name}; - $info->{$snapname}->{order} = $snap->{id}; $info->{$snapname}->{timestamp} = $snap->{'date-sec'}; } -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel