From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A3FD51FF17C for ; Tue, 16 Dec 2025 14:02:43 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D95C5F0C2; Tue, 16 Dec 2025 14:03:08 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Tue, 16 Dec 2025 14:02:16 +0100 Message-ID: <20251216130230.104772-6-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251216130230.104772-1-f.ebner@proxmox.com> References: <20251216130230.104772-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1765890145747 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH storage 05/11] lvm plugin: snapshot delete: clarify comment about using commit X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" The volume size of the child might actually be bigger if there was a resize. However, in terms of actual data that needs to be merged, the child is usually smaller. Signed-off-by: Fiona Ebner --- src/PVE/Storage/LVMPlugin.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm index a134334..0200666 100644 --- a/src/PVE/Storage/LVMPlugin.pm +++ b/src/PVE/Storage/LVMPlugin.pm @@ -1201,7 +1201,8 @@ sub volume_snapshot_delete { my $childvolname = $snapshots->{$childsnap}->{volname}; my $err = undef; - #if first snapshot,as it should be bigger, we merge child, and rename the snapshot to child + # if first snapshot, as it should be bigger in terms of actual data, we merge child, and rename + # the snapshot to child if (!$parentsnap) { print "$volname: deleting snapshot '$snap' by commiting snapshot '$childsnap'\n"; print "running 'qemu-img commit $childpath'\n"; -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel