From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E0A7D1FF17C for ; Tue, 16 Dec 2025 13:57:58 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7B250EAD3; Tue, 16 Dec 2025 13:58:43 +0100 (CET) From: Kefu Chai To: pve-devel@lists.proxmox.com Date: Tue, 16 Dec 2025 20:56:42 +0800 Message-ID: <20251216125648.546017-2-k.chai@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1765889881623 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.008 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [ceph.com] Subject: [pve-devel] [PATCH ceph master v1] backport use-after-fix fix in mgr X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" This change was cherry-picked 941c5eda, which was included in an upstream pull request at https://github.com/ceph/ceph/pull/63989 . Without this change, ceph-mgr could crash when serving a ceph mgr command. Fixes: #6568 Signed-off-by: Kefu Chai --- ...itly-dropping-ref-of-MgrOpRequest.re.patch | 27 +++++++++++++++++++ patches/series | 1 + 2 files changed, 28 insertions(+) create mode 100644 patches/0056-mgr-avoid-explicitly-dropping-ref-of-MgrOpRequest.re.patch diff --git a/patches/0056-mgr-avoid-explicitly-dropping-ref-of-MgrOpRequest.re.patch b/patches/0056-mgr-avoid-explicitly-dropping-ref-of-MgrOpRequest.re.patch new file mode 100644 index 00000000000..661ee825a4e --- /dev/null +++ b/patches/0056-mgr-avoid-explicitly-dropping-ref-of-MgrOpRequest.re.patch @@ -0,0 +1,27 @@ +From 941c5edac00b750e7a0d40c7f8b12b72d39178dc Mon Sep 17 00:00:00 2001 +From: Milind Changire +Date: Fri, 4 Apr 2025 07:20:02 +0530 +Subject: [PATCH] mgr: avoid explicitly dropping ref of MgrOpRequest.request + +Fixes: 66efcaae7a05abaefb12758239b0e1ad5cbd85c9 +Fixes: https://tracker.ceph.com/issues/70618 +Signed-off-by: Milind Changire +--- + src/mgr/MgrOpRequest.h | 1 - + 1 file changed, 1 deletion(-) + +diff --git a/src/mgr/MgrOpRequest.h b/src/mgr/MgrOpRequest.h +index cc454aa6dc8..dd4ff21f5be 100644 +--- a/src/mgr/MgrOpRequest.h ++++ b/src/mgr/MgrOpRequest.h +@@ -52,7 +52,6 @@ protected: + + public: + ~MgrOpRequest() override { +- request->put(); + } + + template +-- +2.47.3 + diff --git a/patches/series b/patches/series index 6dd4562daa3..badc33a9969 100644 --- a/patches/series +++ b/patches/series @@ -53,3 +53,4 @@ 0053-mgr-zabbix-fix-invalid-escape-sequences.patch 0054-client-prohibit-unprivileged-users-from-setting-sgid.patch 0055-pybind-rbd-disable-on_progress-callbacks-to-prevent-.patch +0056-mgr-avoid-explicitly-dropping-ref-of-MgrOpRequest.re.patch -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel