From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id EB3E81FF179 for ; Wed, 10 Dec 2025 19:42:33 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6DD15337C; Wed, 10 Dec 2025 19:42:51 +0100 (CET) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Date: Wed, 10 Dec 2025 19:42:45 +0100 Message-ID: <20251210184247.448937-4-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251210184247.448937-1-s.hanreich@proxmox.com> References: <20251210184247.448937-1-s.hanreich@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.172 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH pve-network 1/1] fix #6806: vlan: qinq: fix bridge port detection X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" When creating a vlan zone and vnet, pve-network looks at all the physical bridge ports (slaves) and adds them to the generated vlan bridge. The zone plugin gets all the bridge interfaces using `/sys/class/net` and then filters them using a regex. With the introduction of network interface pinning, the restrictions on network interface names have gotten more liberal - they're not required to have specific prefixes anymore. The check for physical interfaces in the zones plugin needs to be adjusted to reflect those changes, otherwise the generated SDN configuration does not contain any pinned physical ports and therefore doesn't work. Signed-off-by: Stefan Hanreich --- src/PVE/Network/SDN/Zones/Plugin.pm | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/PVE/Network/SDN/Zones/Plugin.pm b/src/PVE/Network/SDN/Zones/Plugin.pm index a860168..05af47f 100644 --- a/src/PVE/Network/SDN/Zones/Plugin.pm +++ b/src/PVE/Network/SDN/Zones/Plugin.pm @@ -349,13 +349,7 @@ sub is_ovs { sub get_bridge_ifaces { my ($bridge) = @_; - my @bridge_ifaces = (); - my $dir = "/sys/class/net/$bridge/brif"; - PVE::Tools::dir_glob_foreach($dir, '(((eth|bond)\d+|en[^.]+)(\.\d+)?)', sub { - push @bridge_ifaces, $_[0]; - }); - - return @bridge_ifaces; + return PVE::Network::get_physical_bridge_ports($bridge); } sub datacenter_config { -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel