From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 3A6BF1FF183 for ; Wed, 3 Dec 2025 14:29:58 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 04FBB9C7E; Wed, 3 Dec 2025 14:29:59 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Wed, 3 Dec 2025 14:26:30 +0100 Message-ID: <20251203132949.109685-5-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251203132949.109685-1-f.ebner@proxmox.com> References: <20251203132949.109685-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1764768548552 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.019 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [blockdev.pm, monitor.pm, qemuserver.pm] Subject: [pve-devel] [PATCH qemu-server 04/18] monitor: add vm_qmp_peer() helper X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Avoid duplicating this information to ensure consistency and improve readability. Signed-off-by: Fiona Ebner --- src/PVE/QemuServer.pm | 10 ++++------ src/PVE/QemuServer/Blockdev.pm | 4 ++-- src/PVE/QemuServer/Monitor.pm | 9 ++++++++- src/PVE/VZDump/QemuServer.pm | 4 ++-- 4 files changed, 16 insertions(+), 11 deletions(-) diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index ed1cab79..177fc7b1 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -83,7 +83,7 @@ use PVE::QemuServer::DriveDevice qw(print_drivedevice_full scsihw_infos); use PVE::QemuServer::Machine; use PVE::QemuServer::Memory qw(get_current_memory); use PVE::QemuServer::MetaInfo; -use PVE::QemuServer::Monitor qw(mon_cmd); +use PVE::QemuServer::Monitor qw(mon_cmd vm_qmp_peer); use PVE::QemuServer::Network; use PVE::QemuServer::OVMF; use PVE::QemuServer::PCI qw(print_pci_addr print_pcie_addr print_pcie_root_port parse_hostpci); @@ -2733,7 +2733,7 @@ sub vmstatus { my $statuscb = sub { my ($vmid, $resp) = @_; - my $qmp_peer = { name => "VM $vmid", id => $vmid, type => 'qmp' }; + my $qmp_peer = vm_qmp_peer($vmid); $qmpclient->queue_cmd($qmp_peer, $proxmox_support_cb, 'query-proxmox-support'); $qmpclient->queue_cmd($qmp_peer, $blockstatscb, 'query-blockstats'); @@ -2755,8 +2755,7 @@ sub vmstatus { foreach my $vmid (keys %$list) { next if $opt_vmid && ($vmid ne $opt_vmid); next if !$res->{$vmid}->{pid}; # not running - my $qmp_peer = { name => "VM $vmid", id => $vmid, type => 'qmp' }; - $qmpclient->queue_cmd($qmp_peer, $statuscb, 'query-status'); + $qmpclient->queue_cmd(vm_qmp_peer($vmid), $statuscb, 'query-status'); } $qmpclient->queue_execute(undef, 2); @@ -3213,8 +3212,7 @@ sub config_to_command { my $use_virtio = 0; - my $qmpsocket = - PVE::QemuServer::Helpers::qmp_socket({ name => "VM $vmid", id => $vmid, type => 'qmp' }); + my $qmpsocket = PVE::QemuServer::Helpers::qmp_socket(vm_qmp_peer($vmid)); push @$cmd, '-chardev', "socket,id=qmp,path=$qmpsocket,server=on,wait=off"; push @$cmd, '-mon', "chardev=qmp,mode=control"; diff --git a/src/PVE/QemuServer/Blockdev.pm b/src/PVE/QemuServer/Blockdev.pm index af7e769b..17a4c8a0 100644 --- a/src/PVE/QemuServer/Blockdev.pm +++ b/src/PVE/QemuServer/Blockdev.pm @@ -16,7 +16,7 @@ use PVE::QemuServer::BlockJob; use PVE::QemuServer::Drive qw(drive_is_cdrom); use PVE::QemuServer::Helpers; use PVE::QemuServer::Machine; -use PVE::QemuServer::Monitor qw(mon_cmd qmp_cmd); +use PVE::QemuServer::Monitor qw(mon_cmd qmp_cmd vm_qmp_peer); # gives ($host, $port, $export) my $NBD_TCP_PATH_RE_3 = qr/nbd:(\S+):(\d+):exportname=(\S+)/; @@ -583,7 +583,7 @@ sub attach { if ($options->{qsd}) { $qmp_peer = { name => "QEMU storage daemon $id", id => $id, type => 'qsd' }; } else { - $qmp_peer = { name => "VM $id", id => $id, type => 'qmp' }; + $qmp_peer = vm_qmp_peer($id); } my $machine_version; diff --git a/src/PVE/QemuServer/Monitor.pm b/src/PVE/QemuServer/Monitor.pm index e5278881..7ad0f7db 100644 --- a/src/PVE/QemuServer/Monitor.pm +++ b/src/PVE/QemuServer/Monitor.pm @@ -11,6 +11,7 @@ use base 'Exporter'; our @EXPORT_OK = qw( mon_cmd qmp_cmd + vm_qmp_peer ); =head3 qmp_cmd @@ -102,6 +103,12 @@ sub qmp_cmd { return $res; } +sub vm_qmp_peer { + my ($vmid) = @_; + + return { name => "VM $vmid", id => $vmid, type => 'qmp' }; +} + sub qsd_cmd { my ($id, $execute, %params) = @_; @@ -121,7 +128,7 @@ sub hmp_cmd { my ($vmid, $cmdline, $timeout) = @_; return qmp_cmd( - { name => "VM $vmid", id => $vmid, type => 'qmp' }, 'human-monitor-command', + vm_qmp_peer($vmid), 'human-monitor-command', 'command-line' => $cmdline, timeout => $timeout, ); diff --git a/src/PVE/VZDump/QemuServer.pm b/src/PVE/VZDump/QemuServer.pm index 84ebbe80..ef398023 100644 --- a/src/PVE/VZDump/QemuServer.pm +++ b/src/PVE/VZDump/QemuServer.pm @@ -34,7 +34,7 @@ use PVE::QemuServer::Blockdev; use PVE::QemuServer::Drive qw(checked_volume_format); use PVE::QemuServer::Helpers; use PVE::QemuServer::Machine; -use PVE::QemuServer::Monitor qw(mon_cmd); +use PVE::QemuServer::Monitor qw(mon_cmd vm_qmp_peer); use PVE::QemuServer::QMPHelpers; use base qw (PVE::VZDump::Plugin); @@ -995,7 +995,7 @@ sub archive_vma { } my $qmpclient = PVE::QMPClient->new(); - my $qmp_peer = { name => "VM $vmid", id => $vmid, type => 'qmp' }; + my $qmp_peer = vm_qmp_peer($vmid); my $backup_cb = sub { my ($vmid, $resp) = @_; $backup_job_uuid = $resp->{return}->{UUID}; -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel