From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id CB6C51FF183 for ; Wed, 3 Dec 2025 14:29:37 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4FD589C1F; Wed, 3 Dec 2025 14:29:57 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Wed, 3 Dec 2025 14:26:29 +0100 Message-ID: <20251203132949.109685-4-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251203132949.109685-1-f.ebner@proxmox.com> References: <20251203132949.109685-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1764768548496 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.019 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [drive.pm, qemuserver.pm] Subject: [pve-devel] [PATCH qemu-server 03/18] drive: introduce drive_uses_qsd_fuse() helper X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" In preparation for supporting snapshot operations for drives which are QSD FUSE exported. Having a central drive_uses_qsd_fuse() helper makes it possible to consistently decide whether the QMP peer is the QEMU storage daemon or the main QEMU instance. Signed-off-by: Fiona Ebner --- src/PVE/QemuServer.pm | 7 +++---- src/PVE/QemuServer/Drive.pm | 12 ++++++++++++ 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index a7fbec14..ed1cab79 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -2854,12 +2854,11 @@ sub start_swtpm { my $tpm = parse_drive("tpmstate0", $tpmdrive); my ($storeid) = PVE::Storage::parse_volume_id($tpm->{file}, 1); if ($storeid) { - my $format = checked_volume_format($storecfg, $tpm->{file}); - if ($format eq 'raw') { - $state = PVE::Storage::map_volume($storecfg, $tpm->{file}); - } else { + if (PVE::QemuServer::Drive::drive_uses_qsd_fuse($storecfg, $tpm)) { PVE::QemuServer::QSD::start($vmid); $state = PVE::QemuServer::QSD::add_fuse_export($vmid, $tpm, 'tpmstate0'); + } else { + $state = PVE::Storage::map_volume($storecfg, $tpm->{file}); } } else { $state = $tpm->{file}; diff --git a/src/PVE/QemuServer/Drive.pm b/src/PVE/QemuServer/Drive.pm index c772c803..912c2b47 100644 --- a/src/PVE/QemuServer/Drive.pm +++ b/src/PVE/QemuServer/Drive.pm @@ -1149,4 +1149,16 @@ sub detect_zeroes_cmdline_option { return 'on'; } +sub drive_uses_qsd_fuse { + my ($storecfg, $drive) = @_; + + if ($drive->{interface} eq 'tpmstate') { + my ($storeid) = PVE::Storage::parse_volume_id($drive->{file}, 1); + my $format = checked_volume_format($storecfg, $drive->{file}); + return $storeid && $format ne 'raw'; + } + + return; +} + 1; -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel