From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 28EA11FF183 for ; Wed, 3 Dec 2025 14:30:30 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C5148A005; Wed, 3 Dec 2025 14:30:27 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Wed, 3 Dec 2025 14:26:28 +0100 Message-ID: <20251203132949.109685-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251203132949.109685-1-f.ebner@proxmox.com> References: <20251203132949.109685-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1764768548439 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.019 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qmpclient.pm] Subject: [pve-devel] [PATCH qemu-server 02/18] qmp client: add default timeouts for more block commands X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Based on pre-existing defaults for similar commands, commands for adding get 1 minute, commands for creating block jobs or removing get 10 minutes, since those might require in-flight IO to finish. Signed-off-by: Fiona Ebner --- src/PVE/QMPClient.pm | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/PVE/QMPClient.pm b/src/PVE/QMPClient.pm index c3ed0e32..a6f77032 100644 --- a/src/PVE/QMPClient.pm +++ b/src/PVE/QMPClient.pm @@ -120,6 +120,8 @@ sub cmd { $timeout = 3 * 60; } elsif ( $cmd->{execute} eq 'blockdev-add' + || $cmd->{execute} eq 'blockdev-insert-medium' + || $cmd->{execute} eq 'block-export-add' || $cmd->{execute} eq 'device_add' || $cmd->{execute} eq 'device_del' || $cmd->{execute} eq 'netdev_add' @@ -130,8 +132,13 @@ sub cmd { $timeout = 60; } elsif ( $cmd->{execute} eq 'backup-cancel' + || $cmd->{execute} eq 'block-commit' + || $cmd->{execute} eq 'block-export-del' + || $cmd->{execute} eq 'block-stream' || $cmd->{execute} eq 'blockdev-del' || $cmd->{execute} eq 'blockdev-mirror' + || $cmd->{execute} eq 'blockdev-remove-medium' + || $cmd->{execute} eq 'blockdev-reopen' || $cmd->{execute} eq 'block-job-cancel' || $cmd->{execute} eq 'block-job-complete' || $cmd->{execute} eq 'drive-mirror' -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel