From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 1B4141FF183 for ; Wed, 3 Dec 2025 14:31:10 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 32A9DA232; Wed, 3 Dec 2025 14:30:30 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Wed, 3 Dec 2025 14:26:36 +0100 Message-ID: <20251203132949.109685-11-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251203132949.109685-1-f.ebner@proxmox.com> References: <20251203132949.109685-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1764768548892 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.017 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server 10/18] blockdev: switch blockdev_external_snapshot() to use QMP peer X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Signed-off-by: Fiona Ebner --- src/PVE/QemuServer.pm | 8 +++++++- src/PVE/QemuServer/Blockdev.pm | 10 +++++----- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index 638bc215..6f2ee75c 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -4382,7 +4382,13 @@ sub qemu_volume_snapshot { my $snapshots = PVE::Storage::volume_snapshot_info($storecfg, $volid); my $parent_snap = $snapshots->{'current'}->{parent}; PVE::QemuServer::Blockdev::blockdev_external_snapshot( - $storecfg, $vmid, $machine_version, $deviceid, $drive, $snap, $parent_snap, + $storecfg, + vm_qmp_peer($vmid), + $machine_version, + $deviceid, + $drive, + $snap, + $parent_snap, ); } elsif ($do_snapshots_type eq 'storage') { PVE::Storage::volume_snapshot($storecfg, $volid, $snap); diff --git a/src/PVE/QemuServer/Blockdev.pm b/src/PVE/QemuServer/Blockdev.pm index 614d71f4..8db17683 100644 --- a/src/PVE/QemuServer/Blockdev.pm +++ b/src/PVE/QemuServer/Blockdev.pm @@ -856,7 +856,7 @@ sub set_io_throttle { } sub blockdev_external_snapshot { - my ($storecfg, $vmid, $machine_version, $deviceid, $drive, $snap, $parent_snap) = @_; + my ($storecfg, $qmp_peer, $machine_version, $deviceid, $drive, $snap, $parent_snap) = @_; print "Creating a new current volume with $snap as backing snap\n"; @@ -868,7 +868,7 @@ sub blockdev_external_snapshot { #reopen current to snap blockdev_replace( $storecfg, - vm_qmp_peer($vmid), + $qmp_peer, $machine_version, $deviceid, $drive, @@ -895,11 +895,11 @@ sub blockdev_external_snapshot { #backing need to be forced to undef in blockdev, to avoid reopen of backing-file on blockdev-add $new_fmt_blockdev->{backing} = undef; - mon_cmd($vmid, 'blockdev-add', %$new_fmt_blockdev); + qmp_cmd($qmp_peer, 'blockdev-add', %$new_fmt_blockdev); print "blockdev-snapshot: reopen current with $snap backing image\n"; - mon_cmd( - $vmid, 'blockdev-snapshot', + qmp_cmd( + $qmp_peer, 'blockdev-snapshot', node => $snap_fmt_blockdev->{'node-name'}, overlay => $new_fmt_blockdev->{'node-name'}, ); -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel